From b476eca8261095f1853764c9a8ac2938a71e85d1 Mon Sep 17 00:00:00 2001 From: Levi Morrison Date: Fri, 5 Sep 2014 16:07:07 -0600 Subject: [PATCH] Error on multiple default blocks in a switch Part of RFC: https://wiki.php.net/rfc/switch.default.multiple --- Zend/tests/034.phpt | 4 ++-- Zend/zend_compile.c | 5 +++++ 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/Zend/tests/034.phpt b/Zend/tests/034.phpt index 6e46f2645e..0bcfa23f19 100644 --- a/Zend/tests/034.phpt +++ b/Zend/tests/034.phpt @@ -22,5 +22,5 @@ switch (1) { } ?> ---EXPECT-- -3 +--EXPECTF-- +Fatal error: Switch statements may only contain one default clause in %s on line 13 diff --git a/Zend/zend_compile.c b/Zend/zend_compile.c index a5a32298d5..3af97ccc02 100644 --- a/Zend/zend_compile.c +++ b/Zend/zend_compile.c @@ -5091,6 +5091,11 @@ void zend_compile_switch(zend_ast *ast TSRMLS_DC) /* {{{ */ znode cond_node; if (!cond_ast) { + if (has_default_case) { + CG(zend_lineno) = case_ast->lineno; + zend_error_noreturn(E_COMPILE_ERROR, + "Switch statements may only contain one default clause"); + } has_default_case = 1; continue; } -- 2.40.0