From b43e8ad893706a2499c4901b8f5cb289553d66b1 Mon Sep 17 00:00:00 2001 From: Ted Kremenek Date: Thu, 24 Feb 2011 23:03:04 +0000 Subject: [PATCH] Don't warn about using PredefinedExprs as format string literals. These never can be a real security issue. Fixes PR 9314. git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@126447 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/Sema/SemaChecking.cpp | 8 +++++++- test/Sema/format-strings.c | 8 ++++++++ 2 files changed, 15 insertions(+), 1 deletion(-) diff --git a/lib/Sema/SemaChecking.cpp b/lib/Sema/SemaChecking.cpp index 5c2356f54d..97cc44e737 100644 --- a/lib/Sema/SemaChecking.cpp +++ b/lib/Sema/SemaChecking.cpp @@ -875,7 +875,7 @@ bool Sema::SemaBuiltinLongjmp(CallExpr *TheCall) { return false; } -// Handle i > 1 ? "x" : "y", recursivelly +// Handle i > 1 ? "x" : "y", recursively. bool Sema::SemaCheckStringLiteral(const Expr *E, const CallExpr *TheCall, bool HasVAListArg, unsigned format_idx, unsigned firstDataArg, @@ -918,6 +918,12 @@ bool Sema::SemaCheckStringLiteral(const Expr *E, const CallExpr *TheCall, } return false; + case Stmt::PredefinedExprClass: + // While __func__, etc., are technically not string literals, they + // cannot contain format specifiers and thus are not a security + // liability. + return true; + case Stmt::DeclRefExprClass: { const DeclRefExpr *DR = cast(E); diff --git a/test/Sema/format-strings.c b/test/Sema/format-strings.c index fe4f4567cb..c78095a04d 100644 --- a/test/Sema/format-strings.c +++ b/test/Sema/format-strings.c @@ -350,3 +350,11 @@ void posix_extensions() { void pr8486() { printf("%s", 1); // expected-warning{{conversion specifies type 'char *' but the argument has type 'int'}} } + +// PR9314 +// Don't warn about string literals that are PreDefinedExprs, e.g. __func__. +void pr9314() { + printf(__PRETTY_FUNCTION__); // no-warning + printf(__func__); // no-warning +} + -- 2.40.0