From b3f403112d40bc0a6ec240ae1feb536cc6892d47 Mon Sep 17 00:00:00 2001 From: Zhongxing Xu Date: Wed, 16 Jun 2010 05:56:39 +0000 Subject: [PATCH] Although arguments can not be undefined when we get here, they can still be unknown. git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@106085 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/Checker/StreamChecker.cpp | 28 +++++++++++++++------------- 1 file changed, 15 insertions(+), 13 deletions(-) diff --git a/lib/Checker/StreamChecker.cpp b/lib/Checker/StreamChecker.cpp index 3061883706..1fd72b5ce2 100644 --- a/lib/Checker/StreamChecker.cpp +++ b/lib/Checker/StreamChecker.cpp @@ -98,19 +98,21 @@ void StreamChecker::FRead(CheckerContext &C, const CallExpr *CE) { const GRState *state = C.getState(); // Assume CallAndMessageChecker has been run. - const DefinedSVal &StreamVal=cast(state->getSVal(CE->getArg(3))); - - ConstraintManager &CM = C.getConstraintManager(); - const GRState *stateNotNull, *stateNull; - llvm::tie(stateNotNull, stateNull) = CM.AssumeDual(state, StreamVal); - - if (!stateNotNull && stateNull) { - if (ExplodedNode *N = C.GenerateSink(stateNull)) { - if (!BT_nullfp) - BT_nullfp = new BuiltinBug("NULL stream pointer", - "Stream pointer might be NULL."); - BugReport *R = new BugReport(*BT_nullfp, BT_nullfp->getDescription(), N); - C.EmitReport(R); + SVal StreamVal = state->getSVal(CE->getArg(3)); + + if (const DefinedSVal *DV = cast(&StreamVal)) { + ConstraintManager &CM = C.getConstraintManager(); + const GRState *stateNotNull, *stateNull; + llvm::tie(stateNotNull, stateNull) = CM.AssumeDual(state, *DV); + + if (!stateNotNull && stateNull) { + if (ExplodedNode *N = C.GenerateSink(stateNull)) { + if (!BT_nullfp) + BT_nullfp = new BuiltinBug("NULL stream pointer", + "Stream pointer might be NULL."); + BugReport *R =new BugReport(*BT_nullfp, BT_nullfp->getDescription(), N); + C.EmitReport(R); + } } } } -- 2.40.0