From b392d688f855b049badb806abfb5e8d8e2065d04 Mon Sep 17 00:00:00 2001 From: thib Date: Sat, 13 Nov 2004 19:42:39 +0000 Subject: [PATCH] *** empty log message *** --- database.c | 9 ++++++++- doc/en/changes.sgml | 11 ++++++++++- doc/en/todo.sgml | 7 ++++++- fcrontab.c | 7 ++++--- 4 files changed, 28 insertions(+), 6 deletions(-) diff --git a/database.c b/database.c index b906ea1..9351534 100644 --- a/database.c +++ b/database.c @@ -21,7 +21,7 @@ * `LICENSE' that comes with the fcron source distribution. */ - /* $Id: database.c,v 1.73 2004-08-12 09:45:30 thib Exp $ */ + /* $Id: database.c,v 1.74 2004-11-13 19:43:15 thib Exp $ */ #include "fcron.h" @@ -955,6 +955,13 @@ set_next_exe(cl_t *line, char option, int info_fd) set_cl_nextexe: /* set cl_nextexe (handle the timezone differences) */ + + /* TODO : save the ftime.tm_isdst before mktime(), compare the saved value + * to ftime.tm_isdst after mktime() : if it is different, then mktime + * has added or removed one hour because of the daylight saving change : + * then, check it has done what we want or not, and fix nextexe and ftime + * if necessary */ + nextexe = mktime(&ftime); if ( is_random(line->cl_option) ) { diff --git a/doc/en/changes.sgml b/doc/en/changes.sgml index 0e7b962..976f73f 100644 --- a/doc/en/changes.sgml +++ b/doc/en/changes.sgml @@ -8,11 +8,20 @@ Foundation. A copy of the license is included in gfdl.sgml. --> - + Changes + + From version 2.9.5 to 2.9.5.1 + + Fixed serious security vulnerabilities in fcronsighup, + and improved fcronsighup's overall security (drop privileges, + better check user inputs, etc). + + + From version 2.9.4 to 2.9.5 diff --git a/doc/en/todo.sgml b/doc/en/todo.sgml index 6efb5fc..f23a45c 100644 --- a/doc/en/todo.sgml +++ b/doc/en/todo.sgml @@ -8,7 +8,7 @@ Foundation. A copy of the license is included in gfdl.sgml. --> - + Todo @@ -29,6 +29,11 @@ A copy of the license is included in gfdl.sgml. to remove call to "ioctl(fd, TIOCNOTTY, 0);" + + + add something on fcron's incompatibility with Vixie cron @* syntax -- fix that. + + Low priority diff --git a/fcrontab.c b/fcrontab.c index 03e7176..424ddfc 100644 --- a/fcrontab.c +++ b/fcrontab.c @@ -22,7 +22,7 @@ * `LICENSE' that comes with the fcron source distribution. */ - /* $Id: fcrontab.c,v 1.64 2003-12-25 22:42:45 thib Exp $ */ + /* $Id: fcrontab.c,v 1.65 2004-11-13 19:42:39 thib Exp $ */ /* * The goal of this program is simple : giving a user interface to fcron @@ -47,7 +47,7 @@ #include "temp_file.h" #include "read_string.h" -char rcs_info[] = "$Id: fcrontab.c,v 1.64 2003-12-25 22:42:45 thib Exp $"; +char rcs_info[] = "$Id: fcrontab.c,v 1.65 2004-11-13 19:42:39 thib Exp $"; void info(void); void usage(void); @@ -944,12 +944,13 @@ main(int argc, char **argv) /* interpret command line options */ parseopt(argc, argv); -#ifdef USE_SETE_ID if ( ! (pass = getpwnam(USERNAME)) ) die("user \"%s\" is not in passwd file. Aborting.", USERNAME); fcrontab_uid = pass->pw_uid; fcrontab_gid = pass->pw_gid; +#ifdef USE_SETE_ID + #ifdef HAVE_LIBPAM /* Open PAM session for the user and obtain any security credentials we might need */ -- 2.40.0