From b2afca45602cc856f2367e77ca842606aface4ec Mon Sep 17 00:00:00 2001 From: Eric Haszlakiewicz Date: Tue, 5 Sep 2017 01:53:13 -0400 Subject: [PATCH] Issue #173: since some sscanf implementations return 0 for non-zero inputs, directly check for "0" in the input. --- json_util.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/json_util.c b/json_util.c index 2121150..4624668 100644 --- a/json_util.c +++ b/json_util.c @@ -265,7 +265,9 @@ int json_parse_int64(const char *buf, int64_t *retval) // Skip leading zeros, but keep at least one digit while (buf_sig_digits[0] == '0' && buf_sig_digits[1] != '\0') buf_sig_digits++; - if (num64 == 0) // assume all sscanf impl's will parse -0 to 0 + // Can't check num64==0 because some sscanf impl's parse + // non-zero values to 0. (e.g. Illumos with UINT64_MAX) + if (buf_sig_digits[0] == '0' && buf_sig_digits[1] == '\0') orig_has_neg = 0; // "-0" is the same as just plain "0" snprintf(buf_cmp_start, sizeof(buf_cmp), "%" PRId64, num64); -- 2.50.0