From b24d9211329cab87861e25daf6e21210a862d29b Mon Sep 17 00:00:00 2001 From: Chris Lattner Date: Mon, 21 Jul 2008 05:54:02 +0000 Subject: [PATCH] tighten up some checks, don't allow sending a message to NSString**** git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@53836 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/Sema/SemaExprObjC.cpp | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/lib/Sema/SemaExprObjC.cpp b/lib/Sema/SemaExprObjC.cpp index 1067d1fb80..197bf372c4 100644 --- a/lib/Sema/SemaExprObjC.cpp +++ b/lib/Sema/SemaExprObjC.cpp @@ -269,12 +269,13 @@ Sema::ExprResult Sema::ActOnInstanceMessage( return true; } } else { - bool receiverIsQualId = isa(receiverType); - // FIXME (snaroff): checking in this code from Patrick. Needs to be - // revisited. how do we get the ClassDecl from the receiver expression? - if (!receiverIsQualId) - while (const PointerType *PTy = receiverType->getAsPointerType()) + // We allow sending a message to a qualified ID ("id") to an interface + // directly ("[NSNumber foo]") and to a pointer to an interface (an object). + if (!isa(receiverType) && + !isa(receiverType)) + if (const PointerType *PTy = receiverType->getAsPointerType()) receiverType = PTy->getPointeeType(); + // else error, invalid receiver. ObjCInterfaceDecl* ClassDecl = 0; if (ObjCQualifiedIdType *QIT = -- 2.40.0