From b1d82607e6ce3ec30525a49844e914f7194f8b40 Mon Sep 17 00:00:00 2001 From: Chad Sikorra Date: Wed, 29 Jun 2016 07:37:48 -0500 Subject: [PATCH] Add parenthesis to if statements --- ext/ldap/ldap.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/ext/ldap/ldap.c b/ext/ldap/ldap.c index 3b952865c5..3c67a5649f 100644 --- a/ext/ldap/ldap.c +++ b/ext/ldap/ldap.c @@ -2834,10 +2834,10 @@ static zend_string* php_ldap_do_escape(const zend_bool *map, const char *value, len += (map[(unsigned char) value[i]]) ? 3 : 1; } /* Per RFC 4514, a leading and trailing space must be escaped */ - if (flags & PHP_LDAP_ESCAPE_DN && value[0] == ' ') { + if ((flags & PHP_LDAP_ESCAPE_DN) && (value[0] == ' ')) { len += 2; } - if (flags & PHP_LDAP_ESCAPE_DN && valuelen > 1 && value[valuelen - 1] == ' ') { + if ((flags & PHP_LDAP_ESCAPE_DN) && ((valuelen > 1) && (value[valuelen - 1] == ' '))) { len += 2; } @@ -2846,7 +2846,7 @@ static zend_string* php_ldap_do_escape(const zend_bool *map, const char *value, for (i = 0; i < valuelen; i++) { unsigned char v = (unsigned char) value[i]; - if (map[v] || (flags & PHP_LDAP_ESCAPE_DN && (i == 0 || i + 1 == valuelen) && v == ' ')) { + if (map[v] || ((flags & PHP_LDAP_ESCAPE_DN) && ((i == 0) || (i + 1 == valuelen)) && (v == ' '))) { ZSTR_VAL(ret)[p++] = '\\'; ZSTR_VAL(ret)[p++] = hex[v >> 4]; ZSTR_VAL(ret)[p++] = hex[v & 0x0f]; -- 2.50.1