From b11b08e9879c7f1d61e02c662db0bf7104ef49d0 Mon Sep 17 00:00:00 2001 From: Hannes Magnusson Date: Fri, 3 Nov 2006 15:48:39 +0000 Subject: [PATCH] MFH: fix parameter parsing in getrusage() --- README.UPDATE_5_2 | 8 ++++++++ ext/standard/microtime.c | 6 +++++- 2 files changed, 13 insertions(+), 1 deletion(-) diff --git a/README.UPDATE_5_2 b/README.UPDATE_5_2 index 78f69c816a..a9b84950a6 100644 --- a/README.UPDATE_5_2 +++ b/README.UPDATE_5_2 @@ -173,6 +173,14 @@ Items from the NEWS file explained you to fine-grain the levels of the messages stored. +============================== +Backwards incompatible changes +============================== + +In the PHP core +=============== +getrusage() will return NULL when passed incompatible arguments + ================== NEW ERROR MESSAGES ================== diff --git a/ext/standard/microtime.c b/ext/standard/microtime.c index 36c9409688..60a5c5e1dc 100644 --- a/ext/standard/microtime.c +++ b/ext/standard/microtime.c @@ -115,7 +115,11 @@ PHP_FUNCTION(getrusage) long pwho = 0; int who = RUSAGE_SELF; - if (zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "|l", &pwho) != FAILURE && pwho == 1) { + if (zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "|l", &pwho) == FAILURE) { + return; + } + + if (pwho == 1) { who = RUSAGE_CHILDREN; } -- 2.50.1