From b104b1f6ca76cefab25c6ecb5df3bf87a0f875d3 Mon Sep 17 00:00:00 2001 From: Nate Begeman Date: Sun, 15 Feb 2009 22:45:20 +0000 Subject: [PATCH] Don't allow taking the address of an element in an ext_vector git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@64614 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/Sema/SemaExpr.cpp | 6 +++--- test/Sema/expr-address-of.c | 7 ++++++- 2 files changed, 9 insertions(+), 4 deletions(-) diff --git a/lib/Sema/SemaExpr.cpp b/lib/Sema/SemaExpr.cpp index 3143fc7aa1..60a1bea2f4 100644 --- a/lib/Sema/SemaExpr.cpp +++ b/lib/Sema/SemaExpr.cpp @@ -3485,10 +3485,10 @@ QualType Sema::CheckAddressOfOperand(Expr *op, SourceLocation OpLoc) { } } // Check for Apple extension for accessing vector components. - } else if (isa(op) && - cast(op)->getBase()->getType()->isVectorType()) { + } else if (isa(op) || (isa(op) && + cast(op)->getBase()->getType()->isVectorType())){ Diag(OpLoc, diag::err_typecheck_address_of) - << "vector" << op->getSourceRange(); + << "vector element" << op->getSourceRange(); return QualType(); } else if (dcl) { // C99 6.5.3.2p1 // We have an lvalue with a decl. Make sure the decl is not declared diff --git a/test/Sema/expr-address-of.c b/test/Sema/expr-address-of.c index 58bc540a30..7dd7dd67d3 100644 --- a/test/Sema/expr-address-of.c +++ b/test/Sema/expr-address-of.c @@ -28,9 +28,14 @@ void foo() { void testVectorComponentAccess() { typedef float v4sf __attribute__ ((vector_size (16))); static v4sf q; - float* r = &q[0]; // expected-error {{address of vector requested}} + float* r = &q[0]; // expected-error {{address of vector element requested}} } +typedef __attribute__(( ext_vector_type(4) )) float float4; + +float *testExtVectorComponentAccess(float4 x) { + return &x.w; // expected-error {{address of vector element requested}} +} void f0() { register int *x0; -- 2.40.0