From b0b7f4eed1d191402b7ea444e997a08fbcb97969 Mon Sep 17 00:00:00 2001 From: Derick Rethans Date: Mon, 31 Mar 2008 09:12:15 +0000 Subject: [PATCH] - MFH: Fixed a bug in formatting timestamps when DST is active in the default timezone. --- ext/date/php_date.c | 4 ++-- ext/date/tests/timestamp-in-dst.phpt | 11 +++++++++++ 2 files changed, 13 insertions(+), 2 deletions(-) create mode 100644 ext/date/tests/timestamp-in-dst.phpt diff --git a/ext/date/php_date.c b/ext/date/php_date.c index 031cf1cf6b..f1a72e1f98 100644 --- a/ext/date/php_date.c +++ b/ext/date/php_date.c @@ -746,9 +746,9 @@ static char *date_format(char *format, int format_len, timelib_time *t, int loca offset->abbr = strdup(t->tz_abbr); } else if (t->zone_type == TIMELIB_ZONETYPE_OFFSET) { offset = timelib_time_offset_ctor(); - offset->offset = (t->z - (t->dst * 60)) * -60; + offset->offset = (t->z) * -60; offset->leap_secs = 0; - offset->is_dst = t->dst; + offset->is_dst = 0; offset->abbr = malloc(9); /* GMT±xxxx\0 */ snprintf(offset->abbr, 9, "GMT%c%02d%02d", localtime ? ((offset->offset < 0) ? '-' : '+') : '+', diff --git a/ext/date/tests/timestamp-in-dst.phpt b/ext/date/tests/timestamp-in-dst.phpt new file mode 100644 index 0000000000..5b66351e1f --- /dev/null +++ b/ext/date/tests/timestamp-in-dst.phpt @@ -0,0 +1,11 @@ +--TEST-- +Format timestamp in DST test +--INI-- +date.timezone=CEST +--FILE-- +format( 'c' ) ); +?> +--EXPECT-- +string(25) "2008-02-14T13:34:51+00:00" -- 2.40.0