From aec8f4538dfc4fbe9dca92db63688b84f8f0c2a1 Mon Sep 17 00:00:00 2001 From: Chad Rosier Date: Mon, 8 Aug 2011 17:17:15 +0000 Subject: [PATCH] Improved efficiency by using iterator returned by erase, rather then restarting. Thanks to David Blaikie for pointing this out. git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@137051 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/Driver/ArgList.cpp | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/Driver/ArgList.cpp b/lib/Driver/ArgList.cpp index e5341884ee..0d7b057c78 100644 --- a/lib/Driver/ArgList.cpp +++ b/lib/Driver/ArgList.cpp @@ -47,11 +47,11 @@ void ArgList::append(Arg *A) { } void ArgList::eraseArg(OptSpecifier Id) { - for (iterator it = begin(), ie = end(); it != ie; ++it) { + for (iterator it = begin(), ie = end(); it != ie; ) { if ((*it)->getOption().matches(Id)) { - Args.erase(it); - it = begin(); - ie = end(); + it = Args.erase(it); + } else { + ++it; } } } -- 2.40.0