From ae5a2f407272b634c75f7112479ab0babaa25c7b Mon Sep 17 00:00:00 2001 From: "Todd C. Miller" Date: Mon, 11 Jan 2016 16:23:19 -0700 Subject: [PATCH] On overflow, warn before freeing anything. --- plugins/sudoers/ldap.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/plugins/sudoers/ldap.c b/plugins/sudoers/ldap.c index be074ca90..b1c2000ff 100644 --- a/plugins/sudoers/ldap.c +++ b/plugins/sudoers/ldap.c @@ -1361,8 +1361,8 @@ oom: ldap_msgfree(result); debug_return_bool(false); overflow: - free(filt); sudo_warnx(U_("internal error, %s overflow"), __func__); + free(filt); debug_return_bool(false); } @@ -1533,8 +1533,8 @@ oom: ldap_msgfree(result); debug_return_bool(false); overflow: - free(filt); sudo_warnx(U_("internal error, %s overflow"), __func__); + free(filt); debug_return_bool(false); } @@ -1689,8 +1689,8 @@ sudo_ldap_build_pass1(LDAP *ld, struct passwd *pw) debug_return_str(buf); overflow: - free(buf); sudo_warnx(U_("internal error, %s overflow"), __func__); + free(buf); debug_return_str(NULL); } -- 2.40.0