From ae56b6c181f93a82e8e8ed960f9a88f6e0817e0d Mon Sep 17 00:00:00 2001 From: Simon Pilgrim Date: Thu, 3 Oct 2019 21:27:02 +0000 Subject: [PATCH] OverloadCandidate::getNumParams - silence static analyzer getAs null dereference warning. NFCI. The static analyzer is warning about a potential null dereference, but we should be able to use castAs directly and if not assert will fire for us. Also replaces an auto to make the type more obvious. git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@373665 91177308-0d34-0410-b5e6-96231b3b80d8 --- include/clang/Sema/Overload.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/clang/Sema/Overload.h b/include/clang/Sema/Overload.h index e9280103a3..144e6d927c 100644 --- a/include/clang/Sema/Overload.h +++ b/include/clang/Sema/Overload.h @@ -826,10 +826,10 @@ class Sema; unsigned getNumParams() const { if (IsSurrogate) { - auto STy = Surrogate->getConversionType(); + QualType STy = Surrogate->getConversionType(); while (STy->isPointerType() || STy->isReferenceType()) STy = STy->getPointeeType(); - return STy->getAs()->getNumParams(); + return STy->castAs()->getNumParams(); } if (Function) return Function->getNumParams(); -- 2.40.0