From ada5cda0eccb6b33ff00178de06e7190fa7c7798 Mon Sep 17 00:00:00 2001 From: Stefan Marr Date: Mon, 31 Oct 2011 22:59:00 +0000 Subject: [PATCH] Fixed Bug #60173 (Wrong error message on reflective trait instantiation) --- Zend/tests/traits/bug60173.phpt | 12 ++++++++++++ Zend/zend_API.c | 4 +++- 2 files changed, 15 insertions(+), 1 deletion(-) create mode 100644 Zend/tests/traits/bug60173.phpt diff --git a/Zend/tests/traits/bug60173.phpt b/Zend/tests/traits/bug60173.phpt new file mode 100644 index 0000000000..a28a1033a0 --- /dev/null +++ b/Zend/tests/traits/bug60173.phpt @@ -0,0 +1,12 @@ +--TEST-- +Bug #60173 (Wrong error message on reflective trait instantiation) +--FILE-- +newInstance(); + +--EXPECTF-- +Fatal error: Cannot instantiate trait foo in %s on line %d diff --git a/Zend/zend_API.c b/Zend/zend_API.c index ed2f6d6e38..95afc13d9c 100644 --- a/Zend/zend_API.c +++ b/Zend/zend_API.c @@ -1107,7 +1107,9 @@ ZEND_API int _object_and_properties_init(zval *arg, zend_class_entry *class_type zend_object *object; if (class_type->ce_flags & (ZEND_ACC_INTERFACE|ZEND_ACC_IMPLICIT_ABSTRACT_CLASS|ZEND_ACC_EXPLICIT_ABSTRACT_CLASS)) { - char *what = class_type->ce_flags & ZEND_ACC_INTERFACE ? "interface" : "abstract class"; + char *what = (class_type->ce_flags & ZEND_ACC_INTERFACE) ? "interface" + :((class_type->ce_flags & ZEND_ACC_TRAIT) == ZEND_ACC_TRAIT) ? "trait" + : "abstract class"; zend_error(E_ERROR, "Cannot instantiate %s %s", what, class_type->name); } -- 2.50.1