From ac0302ca820b7a58f7af63e18f1a30ffb72d9f73 Mon Sep 17 00:00:00 2001 From: Jonas Hahnfeld Date: Thu, 27 Sep 2018 17:27:48 +0000 Subject: [PATCH] Fix greedy FileCheck expression in test/Driver/mips-abi.c 'ld{{.*}}"' seems to match the complete line for me which is failing the test. Only allow an optional '.exe' for Windows systems as most other tests do. Another possibility would be to collapse the greedy expression with the next check to avoid matching the full line. Differential Revision: https://reviews.llvm.org/D52619 git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@343240 91177308-0d34-0410-b5e6-96231b3b80d8 --- test/Driver/mips-abi.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/test/Driver/mips-abi.c b/test/Driver/mips-abi.c index f6987c13e5..066b81bd95 100644 --- a/test/Driver/mips-abi.c +++ b/test/Driver/mips-abi.c @@ -169,7 +169,7 @@ // TARGET-O32: "-triple" "mips-unknown-linux-gnu" // TARGET-O32: "-target-cpu" "mips32r2" // TARGET-O32: "-target-abi" "o32" -// TARGET-O32: ld{{.*}}" +// TARGET-O32: ld{{(.exe)?}}" // TARGET-O32: "-m" "elf32btsmip" // RUN: %clang -target mips-linux-gnu -mabi=n32 -### %s 2>&1 \ @@ -177,7 +177,7 @@ // TARGET-N32: "-triple" "mips64-unknown-linux-gnu" // TARGET-N32: "-target-cpu" "mips64r2" // TARGET-N32: "-target-abi" "n32" -// TARGET-N32: ld{{.*}}" +// TARGET-N32: ld{{(.exe)?}}" // TARGET-N32: "-m" "elf32btsmipn32" // RUN: %clang -target mips-linux-gnu -mabi=64 -### %s 2>&1 \ @@ -185,5 +185,5 @@ // TARGET-N64: "-triple" "mips64-unknown-linux-gnu" // TARGET-N64: "-target-cpu" "mips64r2" // TARGET-N64: "-target-abi" "n64" -// TARGET-N64: ld{{.*}}" +// TARGET-N64: ld{{(.exe)?}}" // TARGET-N64: "-m" "elf64btsmip" -- 2.50.1