From ab87b8fedce3fa77ca0d684a42ecc055f189eb33 Mon Sep 17 00:00:00 2001 From: Tomas Vondra Date: Sun, 29 Jul 2018 23:08:00 +0200 Subject: [PATCH] Mark variable used only in assertion with PG_USED_FOR_ASSERTS_ONLY Perpendicular lines always intersect, so the line_interpt_line() return value in line_closept_point() was used only in an assertion, triggering compiler warnings in non-assert builds. --- src/backend/utils/adt/geo_ops.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/backend/utils/adt/geo_ops.c b/src/backend/utils/adt/geo_ops.c index 621b5c33ef..4490f933ba 100644 --- a/src/backend/utils/adt/geo_ops.c +++ b/src/backend/utils/adt/geo_ops.c @@ -2528,14 +2528,15 @@ lseg_interpt_line(Point *result, LSEG *lseg, LINE *line) static float8 line_closept_point(Point *result, LINE *line, Point *point) { - bool retval; + bool retval PG_USED_FOR_ASSERTS_ONLY; Point closept; LINE tmp; /* We drop a perpendicular to find the intersection point. */ line_construct(&tmp, point, line_invsl(line)); retval = line_interpt_line(&closept, line, &tmp); - Assert(retval); /* XXX: We need something better. */ + + Assert(retval); /* perpendicular lines always intersect */ if (result != NULL) *result = closept; -- 2.40.0