From ab4702febef82409773f7c80ec02d53ddbb4d80e Mon Sep 17 00:00:00 2001 From: Fariborz Jahanian Date: Tue, 18 Sep 2012 17:46:26 +0000 Subject: [PATCH] minor refactoring of my last check-in. git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@164145 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/Sema/SemaChecking.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/Sema/SemaChecking.cpp b/lib/Sema/SemaChecking.cpp index ed5517d188..77058acc57 100644 --- a/lib/Sema/SemaChecking.cpp +++ b/lib/Sema/SemaChecking.cpp @@ -4355,11 +4355,11 @@ static void AnalyzeComparison(Sema &S, BinaryOperator *E) { QualType T = E->getLHS()->getType(); assert(S.Context.hasSameUnqualifiedType(T, E->getRHS()->getType()) && "comparison with mismatched types"); + if (E->isValueDependent()) + return AnalyzeImpConvsInComparison(S, E); Expr *LHS = E->getLHS()->IgnoreParenImpCasts(); Expr *RHS = E->getRHS()->IgnoreParenImpCasts(); - if (E->isValueDependent()) - return AnalyzeImpConvsInComparison(S, E); bool IsComparisonConstant = false; -- 2.40.0