From ab32ede12a5b4323d735152bc5e0d1898f0bbf39 Mon Sep 17 00:00:00 2001 From: "Todd C. Miller" Date: Sat, 25 Oct 2008 13:22:41 +0000 Subject: [PATCH] In update_defaults() check the return value of user*_matches against ALLOW so we don't inadvertantly match on UNSPEC. --- parse.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/parse.c b/parse.c index cce3afc25..6e9ffcd99 100644 --- a/parse.c +++ b/parse.c @@ -146,22 +146,22 @@ update_defaults(skip_cmnd) if (!set_default(def->var, def->val, def->op)) return(FALSE); case DEFAULTS_USER: - if (userlist_matches(sudo_user.pw, &def->binding) && + if (userlist_matches(sudo_user.pw, &def->binding) == ALLOW && !set_default(def->var, def->val, def->op)) return(FALSE); break; case DEFAULTS_RUNAS: - if (runaslist_matches(&def->binding, NULL) && + if (runaslist_matches(&def->binding, NULL) == ALLOW && !set_default(def->var, def->val, def->op)) return(FALSE); break; case DEFAULTS_HOST: - if (hostlist_matches(&def->binding) && + if (hostlist_matches(&def->binding) == ALLOW && !set_default(def->var, def->val, def->op)) return(FALSE); break; case DEFAULTS_CMND: - if (cmndlist_matches(&def->binding) && + if (cmndlist_matches(&def->binding) == ALLOW && !set_default(def->var, def->val, def->op)) return(FALSE); } -- 2.40.0