From aad87e3f25ad751a3d021c139fd3adbbe1d19fce Mon Sep 17 00:00:00 2001 From: Tom Lane Date: Wed, 6 Nov 2013 13:32:26 -0500 Subject: [PATCH] Prevent creating window functions with default arguments. Insertion of default arguments doesn't work for window functions, which is likely to cause a crash at runtime if the implementation code doesn't check the number of actual arguments carefully. It doesn't seem worth working harder than this for pre-9.2 branches. --- doc/src/sgml/syntax.sgml | 7 +++++++ src/backend/catalog/pg_proc.c | 6 ++++++ 2 files changed, 13 insertions(+) diff --git a/doc/src/sgml/syntax.sgml b/doc/src/sgml/syntax.sgml index 9e87186bb5..863de8852b 100644 --- a/doc/src/sgml/syntax.sgml +++ b/doc/src/sgml/syntax.sgml @@ -2464,6 +2464,13 @@ SELECT concat_lower_or_upper('Hello', 'World', uppercase := true); having numerous parameters that have default values, named or mixed notation can save a great deal of writing and reduce chances for error. + + + + Named and mixed call notations can currently be used only with regular + functions, not with aggregate functions or window functions. + + diff --git a/src/backend/catalog/pg_proc.c b/src/backend/catalog/pg_proc.c index ca21faf7b4..9d5f1a6cbc 100644 --- a/src/backend/catalog/pg_proc.c +++ b/src/backend/catalog/pg_proc.c @@ -285,6 +285,12 @@ ProcedureCreate(const char *procedureName, } } + /* Guard against a case the planner doesn't handle yet */ + if (isWindowFunc && parameterDefaults != NIL) + ereport(ERROR, + (errcode(ERRCODE_FEATURE_NOT_SUPPORTED), + errmsg("window functions cannot have default arguments"))); + /* * All seems OK; prepare the data to be inserted into pg_proc. */ -- 2.50.0