From aa90db947777d7534eb47f5b3184e87d0901fc63 Mon Sep 17 00:00:00 2001 From: Florent Xicluna Date: Sat, 6 Mar 2010 09:54:14 +0000 Subject: [PATCH] #2777: Apply same recipe on win32, i.e. do not inherit file handles. --- Lib/test/test_subprocess.py | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/Lib/test/test_subprocess.py b/Lib/test/test_subprocess.py index cd378a231d..7e96c214e0 100644 --- a/Lib/test/test_subprocess.py +++ b/Lib/test/test_subprocess.py @@ -769,21 +769,23 @@ class Win32ProcessTestCase(unittest.TestCase): self.assertEqual(rc, 47) def test_send_signal(self): - p = subprocess.Popen([sys.executable, "-c", "input()"]) + # Do not inherit file handles from the parent. + # It should fix failure on some platforms. + p = subprocess.Popen([sys.executable, "-c", "input()"], close_fds=True) self.assertIs(p.poll(), None) p.send_signal(signal.SIGTERM) self.assertNotEqual(p.wait(), 0) def test_kill(self): - p = subprocess.Popen([sys.executable, "-c", "input()"]) + p = subprocess.Popen([sys.executable, "-c", "input()"], close_fds=True) self.assertIs(p.poll(), None) p.kill() self.assertNotEqual(p.wait(), 0) def test_terminate(self): - p = subprocess.Popen([sys.executable, "-c", "input()"]) + p = subprocess.Popen([sys.executable, "-c", "input()"], close_fds=True) self.assertIs(p.poll(), None) p.terminate() -- 2.50.0