From aa7eaa93001bd084e0366cac02798ab359884665 Mon Sep 17 00:00:00 2001 From: greg Date: Thu, 6 Oct 2022 17:34:47 -0700 Subject: [PATCH] Increase stack size for dot MSBUILD project file (avoid crash on larger graphs) Comment from Matthew Fernandez: It is believed this resolves some instances of stack overflow in `dfs_enter_outedge` experienced with larger graphs on Windows. Co-authored-by: Matthew Fernandez --- CHANGELOG.md | 5 +++++ cmd/dot/dot.vcxproj | 2 ++ 2 files changed, 7 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index bc9c1223e..83a962b56 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -6,6 +6,11 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ## [Unreleased (6.0.2)] +### Changed + +- Reserved stack size on Windows for the `dot.exe` binary has been increased + from the default 1MB to ~3.8MB. + ### Fixed - Using `aspect` with a custom value in the `packmode` attribute is no longer diff --git a/cmd/dot/dot.vcxproj b/cmd/dot/dot.vcxproj index a2b0ca57c..bbfbe4d2e 100644 --- a/cmd/dot/dot.vcxproj +++ b/cmd/dot/dot.vcxproj @@ -68,6 +68,7 @@ MachineX86 cgraph.lib;gvc.lib;%(AdditionalDependencies) + 4000000 $(OutDir)dot -c @@ -98,6 +99,7 @@ copy /B /Y $(OutDir)dot.exe $(OutDir)twopi.exe MachineX86 cgraph.lib;gvc.lib;%(AdditionalDependencies) + 4000000 $(OutDir)dot -c -- 2.40.0