From aa00851aa4422a5f46529946977334ef807c47fc Mon Sep 17 00:00:00 2001 From: Moriyoshi Koizumi Date: Fri, 4 Apr 2003 14:18:31 +0000 Subject: [PATCH] MFH(r-1.135): fixed memleak in socket_select() --- ext/sockets/sockets.c | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/ext/sockets/sockets.c b/ext/sockets/sockets.c index 54eefb966f..a63a388451 100644 --- a/ext/sockets/sockets.c +++ b/ext/sockets/sockets.c @@ -576,10 +576,21 @@ PHP_FUNCTION(socket_select) /* If seconds is not set to null, build the timeval, else we wait indefinitely */ if (sec != NULL) { - convert_to_long_ex(&sec); + zval tmp; + + if (Z_TYPE_P(sec) != IS_LONG) { + tmp = *sec; + zval_copy_ctor(&tmp); + convert_to_long(&tmp); + sec = &tmp; + } tv.tv_sec = Z_LVAL_P(sec); tv.tv_usec = usec; tv_p = &tv; + + if (sec == &tmp) { + zval_dtor(&tmp); + } } retval = select(max_fd+1, &rfds, &wfds, &efds, tv_p); -- 2.50.1