From a98ad4fabc414c821bfb273f334a5bbccf4a451a Mon Sep 17 00:00:00 2001 From: Tom Lane Date: Sun, 16 Mar 2014 21:55:06 -0400 Subject: [PATCH] Fix unportable shell-script syntax in pg_upgrade's test.sh. I discovered the hard way that on some old shells, the locution FOO="" unset FOO does not behave the same as FOO=""; unset FOO and in fact leaves FOO set to an empty string. test.sh was inconsistently spelling it different ways on adjacent lines. This got broken relatively recently, in commit c737a2e56, so the lack of field reports to date doesn't represent a lot of evidence that the problem is rare. --- contrib/pg_upgrade/test.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/contrib/pg_upgrade/test.sh b/contrib/pg_upgrade/test.sh index a109b5b196..21a44b4b44 100644 --- a/contrib/pg_upgrade/test.sh +++ b/contrib/pg_upgrade/test.sh @@ -83,10 +83,10 @@ mkdir "$logdir" PGDATABASE=""; unset PGDATABASE PGUSER=""; unset PGUSER PGSERVICE=""; unset PGSERVICE -PGSSLMODE="" unset PGSSLMODE +PGSSLMODE=""; unset PGSSLMODE PGREQUIRESSL=""; unset PGREQUIRESSL PGCONNECT_TIMEOUT=""; unset PGCONNECT_TIMEOUT -PGHOST="" unset PGHOST +PGHOST=""; unset PGHOST PGHOSTADDR=""; unset PGHOSTADDR # Select a non-conflicting port number, similarly to pg_regress.c -- 2.40.0