From a91efb14cbf6af999dee02d9b611a57c7b52e209 Mon Sep 17 00:00:00 2001 From: Anna Zaks Date: Tue, 6 Dec 2011 23:12:38 +0000 Subject: [PATCH] [analyzer] Add comments related to symbol_iterator git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@145987 91177308-0d34-0410-b5e6-96231b3b80d8 --- .../clang/StaticAnalyzer/Core/PathSensitive/SymbolManager.h | 6 +++++- lib/StaticAnalyzer/Core/ProgramState.cpp | 1 + 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/include/clang/StaticAnalyzer/Core/PathSensitive/SymbolManager.h b/include/clang/StaticAnalyzer/Core/PathSensitive/SymbolManager.h index d47363cc10..0c8196e1ab 100644 --- a/include/clang/StaticAnalyzer/Core/PathSensitive/SymbolManager.h +++ b/include/clang/StaticAnalyzer/Core/PathSensitive/SymbolManager.h @@ -70,6 +70,11 @@ public: // Implement isa support. static inline bool classof(const SymExpr*) { return true; } + /// \brief Iterator over symbols that the current symbol depends on. + /// + /// For SymbolData, it's the symbol itself; for expressions, it's the + /// expression symbol and all the operands in it. Note, SymbolDerived is + /// treated as SymbolData - the iterator will NOT visit the parent region. class symbol_iterator { SmallVector itr; void expand(); @@ -87,7 +92,6 @@ public: symbol_iterator symbol_begin() const { return symbol_iterator(this); } - static symbol_iterator symbol_end() { return symbol_iterator(); } }; diff --git a/lib/StaticAnalyzer/Core/ProgramState.cpp b/lib/StaticAnalyzer/Core/ProgramState.cpp index a725d38192..2f9a3929e8 100644 --- a/lib/StaticAnalyzer/Core/ProgramState.cpp +++ b/lib/StaticAnalyzer/Core/ProgramState.cpp @@ -553,6 +553,7 @@ bool ScanReachableSymbols::scan(const SymExpr *sym) { if (!visitor.VisitSymbol(sym)) return false; + // TODO: should be rewritten using SymExpr::symbol_iterator. switch (sym->getKind()) { case SymExpr::RegionValueKind: case SymExpr::ConjuredKind: -- 2.50.1