From a8a175e0de5c36a2d1d6a24527717f46fe6334d3 Mon Sep 17 00:00:00 2001 From: Rafael Espindola Date: Wed, 11 Oct 2017 17:23:15 +0000 Subject: [PATCH] Convert a few ErrorOr to Expected. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@315477 91177308-0d34-0410-b5e6-96231b3b80d8 --- include/llvm/Object/COFF.h | 16 ++++++++-------- tools/llvm-objdump/COFFDump.cpp | 4 ++-- tools/llvm-readobj/COFFDumper.cpp | 8 ++++---- 3 files changed, 14 insertions(+), 14 deletions(-) diff --git a/include/llvm/Object/COFF.h b/include/llvm/Object/COFF.h index 1a0f9441e2a..82861240cb1 100644 --- a/include/llvm/Object/COFF.h +++ b/include/llvm/Object/COFF.h @@ -954,28 +954,28 @@ public: Res = reinterpret_cast(getSymbolTable()) + Index; return std::error_code(); } - ErrorOr getSymbol(uint32_t index) const { + Expected getSymbol(uint32_t index) const { if (SymbolTable16) { const coff_symbol16 *Symb = nullptr; if (std::error_code EC = getSymbol(index, Symb)) - return EC; + return errorCodeToError(EC); return COFFSymbolRef(Symb); } if (SymbolTable32) { const coff_symbol32 *Symb = nullptr; if (std::error_code EC = getSymbol(index, Symb)) - return EC; + return errorCodeToError(EC); return COFFSymbolRef(Symb); } - return object_error::parse_failed; + return errorCodeToError(object_error::parse_failed); } template std::error_code getAuxSymbol(uint32_t index, const T *&Res) const { - ErrorOr s = getSymbol(index); - if (std::error_code EC = s.getError()) - return EC; - Res = reinterpret_cast(s->getRawPtr()); + Expected S = getSymbol(index); + if (Error E = S.takeError()) + return errorToErrorCode(std::move(E)); + Res = reinterpret_cast(S->getRawPtr()); return std::error_code(); } diff --git a/tools/llvm-objdump/COFFDump.cpp b/tools/llvm-objdump/COFFDump.cpp index db549bbe3ee..8d38c8d9fb9 100644 --- a/tools/llvm-objdump/COFFDump.cpp +++ b/tools/llvm-objdump/COFFDump.cpp @@ -641,9 +641,9 @@ void llvm::printCOFFSymbolTable(const object::COFFImportFile *i) { void llvm::printCOFFSymbolTable(const COFFObjectFile *coff) { for (unsigned SI = 0, SE = coff->getNumberOfSymbols(); SI != SE; ++SI) { - ErrorOr Symbol = coff->getSymbol(SI); + Expected Symbol = coff->getSymbol(SI); StringRef Name; - error(Symbol.getError()); + error(errorToErrorCode(Symbol.takeError())); error(coff->getSymbolName(*Symbol, Name)); outs() << "[" << format("%2d", SI) << "]" diff --git a/tools/llvm-readobj/COFFDumper.cpp b/tools/llvm-readobj/COFFDumper.cpp index 8f668b9953a..1ce00610edd 100644 --- a/tools/llvm-readobj/COFFDumper.cpp +++ b/tools/llvm-readobj/COFFDumper.cpp @@ -1423,9 +1423,9 @@ void COFFDumper::printSymbol(const SymbolRef &Sym) { const coff_aux_weak_external *Aux; error(getSymbolAuxData(Obj, Symbol, I, Aux)); - ErrorOr Linked = Obj->getSymbol(Aux->TagIndex); + Expected Linked = Obj->getSymbol(Aux->TagIndex); StringRef LinkedName; - std::error_code EC = Linked.getError(); + std::error_code EC = errorToErrorCode(Linked.takeError()); if (EC || (EC = Obj->getSymbolName(*Linked, LinkedName))) { LinkedName = ""; error(EC); @@ -1481,10 +1481,10 @@ void COFFDumper::printSymbol(const SymbolRef &Sym) { const coff_aux_clr_token *Aux; error(getSymbolAuxData(Obj, Symbol, I, Aux)); - ErrorOr ReferredSym = + Expected ReferredSym = Obj->getSymbol(Aux->SymbolTableIndex); StringRef ReferredName; - std::error_code EC = ReferredSym.getError(); + std::error_code EC = errorToErrorCode(ReferredSym.takeError()); if (EC || (EC = Obj->getSymbolName(*ReferredSym, ReferredName))) { ReferredName = ""; error(EC); -- 2.50.1