From a89330c3b853a2fde8442f217d612d9fcca97bda Mon Sep 17 00:00:00 2001
From: Rich Bowen <rbowen@apache.org>
Date: Sat, 27 Nov 2010 02:29:47 +0000
Subject: [PATCH] Get the output of -x (the xml containing the missing
 directives) all as one lump, rather than one directive at a time.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1039598 13f79535-47bb-0310-9956-ffa450edef68
---
 docs/review_translations.pl | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/docs/review_translations.pl b/docs/review_translations.pl
index 7b6c061554..ad2edf83f3 100755
--- a/docs/review_translations.pl
+++ b/docs/review_translations.pl
@@ -48,9 +48,17 @@ foreach my $file (@files) {
     print "Translation available in ". ($LANGS{$lang}?$LANGS{$lang}:$lang) ."\n";
     my $lang_xml = $xs->XMLin( $file );
 
+    my @missing;
     foreach my $d ( @directives ) {
         unless ( defined( $lang_xml->{directivesynopsis}->{$d} ) ) {
             print "Translation does not define $d\n";
+            push @missing, $d;
+        }
+    }
+
+    if ( $opt_x && @missing ) {
+        print "\nPaste the following into the XML:\n\n";
+        foreach my $d ( @missing ) {
             directive_doc( $d, $eng_xml ) if $opt_x;
         }
     }
@@ -60,9 +68,7 @@ foreach my $file (@files) {
 
 sub directive_doc {
     my ($d, $eng_xml) = @_;
-# print Dumper( $eng_xml->{directivesynopsis}->{$d} );
 
-    print "\nPaste the following into the XML:\n\n";
     print "<directivesynopsis>\n";
     print "<name>" . $d . "</name>\n";
     print "<description>" .
-- 
2.40.0