From a76c857eba977a91a07ab752d4811eb5734f0b5c Mon Sep 17 00:00:00 2001 From: Peter Eisentraut Date: Mon, 16 Jul 2012 22:08:04 +0300 Subject: [PATCH] Add comment why seemingly dead code is necessary --- src/pl/plperl/plperl.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/src/pl/plperl/plperl.c b/src/pl/plperl/plperl.c index db584c4e7e..4415efafec 100644 --- a/src/pl/plperl/plperl.c +++ b/src/pl/plperl/plperl.c @@ -832,7 +832,15 @@ pp_require_safe(pTHX) RETPUSHYES; DIE(aTHX_ "Unable to load %s into plperl", name); - return NULL; /* keep compiler quiet */ + /* + * In most Perl versions, DIE() expands to a return statement, so the next + * line is not necessary. But in versions between but not including 5.11.1 + * and 5.13.3 it does not, so the next line is necessary to avoid a + * "control reaches end of non-void function" warning from gcc. Other + * compilers such as Solaris Studio will, however, issue a "statement not + * reached" warning instead. + */ + return NULL; } -- 2.40.0