From a6886d2345efd077f73e72c0a78a5da39ca66bf6 Mon Sep 17 00:00:00 2001 From: "Todd C. Miller" Date: Mon, 25 Jan 2016 16:18:22 -0700 Subject: [PATCH] Add check for I/O log file handle being NULL. This could only happen if the front-end calls iolog_open with argc == 0 but actually runs a command. --- plugins/sudoers/iolog.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/plugins/sudoers/iolog.c b/plugins/sudoers/iolog.c index c7b4584cd..6b33c195b 100644 --- a/plugins/sudoers/iolog.c +++ b/plugins/sudoers/iolog.c @@ -719,6 +719,12 @@ sudoers_io_log(const char *buf, unsigned int len, int idx) int rval = true; debug_decl(sudoers_io_version, SUDOERS_DEBUG_PLUGIN) + if (io_log_files[idx].fd.v == NULL) { + sudo_warnx(U_("%s: internal error, file index %d not open"), + __func__, idx); + debug_return_int(-1); + } + gettimeofday(&now, NULL); #ifdef HAVE_ZLIB_H -- 2.50.1