From a5ec41d9a9a577b91f3390a46590a5827a84d6dd Mon Sep 17 00:00:00 2001 From: Vedant Kumar Date: Fri, 15 Jul 2016 22:44:54 +0000 Subject: [PATCH] [llvm-cov] Document a few private fields of CodeCoverageTool (NFC) git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@275639 91177308-0d34-0410-b5e6-96231b3b80d8 --- tools/llvm-cov/CodeCoverage.cpp | 3 +++ tools/llvm-cov/CoverageViewOptions.h | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/tools/llvm-cov/CodeCoverage.cpp b/tools/llvm-cov/CodeCoverage.cpp index ed48c28c0fc..59cb708a42c 100644 --- a/tools/llvm-cov/CodeCoverage.cpp +++ b/tools/llvm-cov/CodeCoverage.cpp @@ -101,11 +101,14 @@ public: std::string CoverageArch; private: + /// File paths (absolute, or otherwise) to input source files. std::vector CollectedPaths; + /// Errors and warnings which have not been printed. std::mutex DeferredMessagesLock; std::vector DeferredMessages; + /// A container for input source file buffers. std::mutex LoadedSourceFilesLock; std::vector>> LoadedSourceFiles; diff --git a/tools/llvm-cov/CoverageViewOptions.h b/tools/llvm-cov/CoverageViewOptions.h index 873eae885a7..eafc0cfd165 100644 --- a/tools/llvm-cov/CoverageViewOptions.h +++ b/tools/llvm-cov/CoverageViewOptions.h @@ -40,7 +40,7 @@ struct CoverageViewOptions { } /// \brief Check if an output directory has been specified. - bool hasOutputDirectory() const { return ShowOutputDirectory != ""; } + bool hasOutputDirectory() const { return !ShowOutputDirectory.empty(); } }; } -- 2.40.0