From a5e558a3f58e10a3dd34b50531245145aa0a3ba8 Mon Sep 17 00:00:00 2001 From: Nico Weber Date: Sat, 10 May 2014 23:56:43 +0000 Subject: [PATCH] Don't leak CXStrings for replacement fix-its in c-index-test. The loop body used to contain a switch statement; it looks like r96685 replaced that with an if/else if/else but accidentally left one of the three break statements from the switch behind, skipping the clang_disposeString() call for replacements (and the rest of the loop too, which apparently doesn't make a differences for the test cases we have). r96685: http://lists.cs.uiuc.edu/pipermail/cfe-commits/Week-of-Mon-20100215/027754.html This too might possibly the last leak in clang (PR19521). git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@208483 91177308-0d34-0410-b5e6-96231b3b80d8 --- tools/c-index-test/c-index-test.c | 1 - 1 file changed, 1 deletion(-) diff --git a/tools/c-index-test/c-index-test.c b/tools/c-index-test/c-index-test.c index fd2b120f41..99f291ddd7 100644 --- a/tools/c-index-test/c-index-test.c +++ b/tools/c-index-test/c-index-test.c @@ -977,7 +977,6 @@ void PrintDiagnostic(CXDiagnostic Diagnostic) { PrintExtent(out, start_line, start_column, end_line, end_column); fprintf(out, " with \"%s\"\n", clang_getCString(insertion_text)); } - break; } clang_disposeString(insertion_text); } -- 2.50.1