From a59318346ef476d3e66c4d13e92cf4ad6ce328ac Mon Sep 17 00:00:00 2001 From: Tom Lane Date: Mon, 6 Feb 2017 11:31:23 -0500 Subject: [PATCH] Update comment in relcache.c. Commit 665d1fad9 introduced rd_pkindex, and made RelationGetIndexList responsible for updating it, but didn't bother to fix RelationGetIndexList's header comment to say so. --- src/backend/utils/cache/relcache.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/src/backend/utils/cache/relcache.c b/src/backend/utils/cache/relcache.c index 4dd2e2b2c6..e9295a99f8 100644 --- a/src/backend/utils/cache/relcache.c +++ b/src/backend/utils/cache/relcache.c @@ -4327,9 +4327,10 @@ RelationGetFKeyList(Relation relation) * it is the pg_class OID of a unique index on OID when the relation has one, * and InvalidOid if there is no such index. * - * In exactly the same way, we update rd_replidindex, which is the pg_class - * OID of an index to be used as the relation's replication identity index, - * or InvalidOid if there is no such index. + * In exactly the same way, we update rd_pkindex, which is the OID of the + * relation's primary key index if any, else InvalidOid; and rd_replidindex, + * which is the pg_class OID of an index to be used as the relation's + * replication identity index, or InvalidOid if there is no such index. */ List * RelationGetIndexList(Relation relation) @@ -4797,7 +4798,7 @@ RelationGetIndexAttrBitmap(Relation relation, IndexAttrBitmapKind attrKind) return NULL; /* - * Copy the rd_pkindex and rd_replidindex value computed by + * Copy the rd_pkindex and rd_replidindex values computed by * RelationGetIndexList before proceeding. This is needed because a * relcache flush could occur inside index_open below, resetting the * fields managed by RelationGetIndexList. (The values we're computing -- 2.40.0