From a53112338c2f5b74383ce075fbec098cd06a3ad7 Mon Sep 17 00:00:00 2001 From: Andrew Dunstan Date: Thu, 7 Apr 2011 22:17:06 -0400 Subject: [PATCH] Avoid use of mixed slash style paths in arguments to xcopy in MSVC builds. Some versions of xcopy, notably on Windows 7 don't like it. Backpatch to 8.3, where we first used xcopy. --- src/tools/msvc/Install.pm | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/tools/msvc/Install.pm b/src/tools/msvc/Install.pm index e1747c4fda..f1028b7374 100644 --- a/src/tools/msvc/Install.pm +++ b/src/tools/msvc/Install.pm @@ -479,15 +479,17 @@ sub CopyIncludeFiles my $D; opendir($D, 'src/include') || croak "Could not opendir on src/include!\n"; + # some xcopy progs don't like mixed slash style paths + (my $ctarget = $target) =~ s!/!\\!g; while (my $d = readdir($D)) { next if ($d =~ /^\./); next if ($d eq '.git'); next if ($d eq 'CVS'); - next unless (-d 'src/include/' . $d); + next unless (-d "src/include/$d"); - EnsureDirectories($target . '/include/server', $d); - system("xcopy /s /i /q /r /y src\\include\\$d\\*.h \"$target\\include\\server\\$d\\\"") + EnsureDirectories("$target/include/server/$d"); + system(qq{xcopy /s /i /q /r /y src\\include\\$d\\*.h "$ctarget\\include\\server\\$d\\"}) && croak("Failed to copy include directory $d\n"); } closedir($D); -- 2.40.0