From a4775a80fd444162ff878d2e945c8af7ba37eb89 Mon Sep 17 00:00:00 2001 From: Tom Lane Date: Fri, 18 Jul 2008 04:20:24 +0000 Subject: [PATCH] Suppress compiler warning, and not incidentally make the code more robust. The previous coding was quite risky because it was testing conditions different from 'is the array really allocated?'. --- src/bin/psql/describe.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/bin/psql/describe.c b/src/bin/psql/describe.c index 0a0819cc02..137ea6c2d4 100644 --- a/src/bin/psql/describe.c +++ b/src/bin/psql/describe.c @@ -8,7 +8,7 @@ * * Copyright (c) 2000-2008, PostgreSQL Global Development Group * - * $PostgreSQL: pgsql/src/bin/psql/describe.c,v 1.183 2008/07/18 03:32:52 tgl Exp $ + * $PostgreSQL: pgsql/src/bin/psql/describe.c,v 1.184 2008/07/18 04:20:24 tgl Exp $ */ #include "postgres_fe.h" @@ -1591,14 +1591,14 @@ error_return: termPQExpBuffer(&title); termPQExpBuffer(&tmpbuf); - if (tableinfo.relkind == 'S') + if (seq_values) { for (ptr = seq_values; *ptr; ptr++) free(*ptr); free(seq_values); } - if (show_modifiers) + if (modifiers) { for (ptr = modifiers; *ptr; ptr++) free(*ptr); -- 2.40.0