From a3faa5a0e193a4fac5bb77d824be62c38f660052 Mon Sep 17 00:00:00 2001 From: Ilya Biryukov Date: Wed, 21 Jun 2017 12:34:27 +0000 Subject: [PATCH] Fixed compiler warnings after r305890. Should fix buildbots that pass -Werror. git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@305902 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/Frontend/ASTUnit.cpp | 14 ++++---------- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/lib/Frontend/ASTUnit.cpp b/lib/Frontend/ASTUnit.cpp index 238ac33931..1f34f10f55 100644 --- a/lib/Frontend/ASTUnit.cpp +++ b/lib/Frontend/ASTUnit.cpp @@ -924,9 +924,6 @@ public: class ASTUnitPreambleCallbacks : public PreambleCallbacks { public: - ASTUnitPreambleCallbacks(llvm::SmallVectorImpl &StoredDiags) - : StoredDiags(StoredDiags) {} - unsigned getHash() const { return Hash; } std::vector takeTopLevelDecls() { return std::move(TopLevelDecls); } @@ -964,7 +961,6 @@ public: } private: - llvm::SmallVectorImpl &StoredDiags; unsigned Hash = 0; std::vector TopLevelDecls; std::vector TopLevelDeclIDs; @@ -1259,7 +1255,7 @@ ASTUnit::getMainBufferWithPrecompiledPreamble( SmallVector NewPreambleDiagsStandalone; SmallVector NewPreambleDiags; - ASTUnitPreambleCallbacks Callbacks(NewPreambleDiags); + ASTUnitPreambleCallbacks Callbacks; { llvm::Optional Capture; if (CaptureDiagnostics) @@ -1282,18 +1278,16 @@ ASTUnit::getMainBufferWithPrecompiledPreamble( case BuildPreambleError::PreambleIsEmpty: // Try again next time. PreambleRebuildCounter = 1; - break; + return nullptr; case BuildPreambleError::CouldntCreateTargetInfo: case BuildPreambleError::BeginSourceFileFailed: case BuildPreambleError::CouldntEmitPCH: case BuildPreambleError::CouldntCreateVFSOverlay: // These erros are more likely to repeat, retry after some period. PreambleRebuildCounter = DefaultPreambleRebuildInterval; - break; - default: - llvm_unreachable("unexpected BuildPreambleError"); + return nullptr; } - return nullptr; + llvm_unreachable("unexpected BuildPreambleError"); } } -- 2.50.1