From a32fe9277c81f89fbba89ff025cca07d83498bc1 Mon Sep 17 00:00:00 2001 From: Eli Friedman Date: Wed, 19 Oct 2016 22:16:32 +0000 Subject: [PATCH] Don't crash generating debug info for VLA in function prototype. Fixes regression from r279445. Differential Revision: https://reviews.llvm.org/D25793 git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@284652 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/CodeGen/CGDebugInfo.cpp | 8 +++++--- test/CodeGenCXX/debug-info-vla.cpp | 16 ++++++++++++---- 2 files changed, 17 insertions(+), 7 deletions(-) diff --git a/lib/CodeGen/CGDebugInfo.cpp b/lib/CodeGen/CGDebugInfo.cpp index ef8f31e574..1d80a1bf9d 100644 --- a/lib/CodeGen/CGDebugInfo.cpp +++ b/lib/CodeGen/CGDebugInfo.cpp @@ -2180,9 +2180,11 @@ llvm::DIType *CGDebugInfo::CreateType(const ArrayType *Ty, llvm::DIFile *Unit) { if (const auto *CAT = dyn_cast(Ty)) Count = CAT->getSize().getZExtValue(); else if (const auto *VAT = dyn_cast(Ty)) { - llvm::APSInt V; - if (VAT->getSizeExpr()->EvaluateAsInt(V, CGM.getContext())) - Count = V.getExtValue(); + if (Expr *Size = VAT->getSizeExpr()) { + llvm::APSInt V; + if (Size->EvaluateAsInt(V, CGM.getContext())) + Count = V.getExtValue(); + } } // FIXME: Verify this is right for VLAs. diff --git a/test/CodeGenCXX/debug-info-vla.cpp b/test/CodeGenCXX/debug-info-vla.cpp index 024ee3a6f9..cd9b7f6c45 100644 --- a/test/CodeGenCXX/debug-info-vla.cpp +++ b/test/CodeGenCXX/debug-info-vla.cpp @@ -1,14 +1,22 @@ -// RUN: %clang -target x86_64-unknown-unknown -fverbose-asm -g -O0 -S -emit-llvm %s -o - | FileCheck %s +// RUN: %clang -target x86_64-unknown-unknown -fverbose-asm -g -O0 -S -emit-llvm %s -o - -std=c++11 | FileCheck %s void f(int m) { int x[3][m]; } +int (*fp)(int[][*]) = nullptr; + +// CHECK: !DICompositeType(tag: DW_TAG_array_type, +// CHECK-NOT: size: +// CHECK-SAME: align: 32 +// CHECK-SAME: elements: [[ELEM_TYPE:![0-9]+]] +// CHECK: [[ELEM_TYPE]] = !{[[NOCOUNT:.*]]} +// CHECK: [[NOCOUNT]] = !DISubrange(count: -1) +// // CHECK: !DICompositeType(tag: DW_TAG_array_type, // CHECK-NOT: size: // CHECK-SAME: align: 32 // CHECK-SAME: elements: [[ELEM_TYPE:![0-9]+]] -// CHECK: [[ELEM_TYPE]] = !{[[SUB1:.*]], [[SUB2:.*]]} -// CHECK: [[SUB1]] = !DISubrange(count: 3) -// CHECK: [[SUB2]] = !DISubrange(count: -1) +// CHECK: [[ELEM_TYPE]] = !{[[THREE:.*]], [[NOCOUNT]]} +// CHECK: [[THREE]] = !DISubrange(count: 3) -- 2.40.0