From a30aa7271683f9a14ab348f2696f9aee27637f24 Mon Sep 17 00:00:00 2001 From: Remi Gacogne Date: Thu, 3 Oct 2019 15:41:46 +0200 Subject: [PATCH] dnsdist: Compile with -Wall -Wextra -Wshadow by default And -Werror=vla -Werror=shadow -Wformat=2 -Werror=format-security in CircleCI. --- .circleci/config.yml | 8 ++++---- pdns/dnsdistdist/configure.ac | 4 ++-- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index 6e5084cc0..7ea68d4ab 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -1097,8 +1097,8 @@ jobs: - run: name: configure command: | - CFLAGS="-O1 -Werror=vla -Wformat=2 -Werror=format-security" \ - CXXFLAGS="-O1 -Werror=vla -Wformat=2 -Werror=format-security -Wp,-D_GLIBCXX_ASSERTIONS" \ + CFLAGS="-O1 -Werror=vla -Werror=shadow -Wformat=2 -Werror=format-security" \ + CXXFLAGS="-O1 -Werror=vla -Werror=shadow -Wformat=2 -Werror=format-security -Wp,-D_GLIBCXX_ASSERTIONS" \ ./configure \ --disable-systemd \ --disable-unit-tests \ @@ -1247,8 +1247,8 @@ jobs: - run: name: configure command: | - CFLAGS="-O1 -Werror=vla -Wformat=2 -Werror=format-security" \ - CXXFLAGS="-O1 -Werror=vla -Wformat=2 -Werror=format-security -Wp,-D_GLIBCXX_ASSERTIONS" \ + CFLAGS="-O1 -Werror=vla -Werror=shadow -Wformat=2 -Werror=format-security" \ + CXXFLAGS="-O1 -Werror=vla -Werror=shadow -Wformat=2 -Werror=format-security -Wp,-D_GLIBCXX_ASSERTIONS" \ ./configure \ --enable-unit-tests \ --enable-dnstap \ diff --git a/pdns/dnsdistdist/configure.ac b/pdns/dnsdistdist/configure.ac index 88eabe39d..3b34f371b 100644 --- a/pdns/dnsdistdist/configure.ac +++ b/pdns/dnsdistdist/configure.ac @@ -17,8 +17,8 @@ AC_DEFINE([DNSDIST], [1], LT_PREREQ([2.2.2]) LT_INIT([disable-static]) -CFLAGS="-Wall -g -O3 $CFLAGS" -CXXFLAGS="-Wall -g -O3 $CXXFLAGS" +CFLAGS="-Wall -g -O3 $CFLAGS -Wall -Wextra -Wshadow -Wno-unused-parameter" +CXXFLAGS="-Wall -g -O3 $CXXFLAGS -Wall -Wextra -Wshadow -Wno-unused-parameter" PDNS_WITH_LIBSODIUM PDNS_CHECK_DNSTAP([auto]) -- 2.49.0