From a2102e1a92bf0b485487b0582f2efaa9ff025556 Mon Sep 17 00:00:00 2001 From: Alvaro Herrera Date: Thu, 15 Mar 2018 09:51:12 -0300 Subject: [PATCH] test_ddl_deparse: Don't use pg_class as source for a matview Doing so causes a pg_upgrade of a database containing these objects to fail whenever pg_class changes. And it's pointless anyway: we have more interesting tables anyhow. Discussion: https://postgr.es/m/CAD5tBc+s8pW9WvH2+_z=B4x95FD4QuzZKcaMpff_9H4rS0VU1A@mail.gmail.com --- src/test/modules/test_ddl_deparse/expected/matviews.out | 2 +- src/test/modules/test_ddl_deparse/sql/matviews.sql | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/test/modules/test_ddl_deparse/expected/matviews.out b/src/test/modules/test_ddl_deparse/expected/matviews.out index b946ff06d2..4ac2cc8325 100644 --- a/src/test/modules/test_ddl_deparse/expected/matviews.out +++ b/src/test/modules/test_ddl_deparse/expected/matviews.out @@ -2,7 +2,7 @@ -- Materialized views -- CREATE MATERIALIZED VIEW pg_class_mv AS - SELECT * FROM pg_class LIMIT 1 WITH NO DATA; + SELECT * FROM datatype_table LIMIT 1 WITH NO DATA; NOTICE: DDL test: type simple, tag CREATE MATERIALIZED VIEW REFRESH MATERIALIZED VIEW pg_class_mv; NOTICE: DDL test: type simple, tag REFRESH MATERIALIZED VIEW diff --git a/src/test/modules/test_ddl_deparse/sql/matviews.sql b/src/test/modules/test_ddl_deparse/sql/matviews.sql index 381c11e1f8..990082934e 100644 --- a/src/test/modules/test_ddl_deparse/sql/matviews.sql +++ b/src/test/modules/test_ddl_deparse/sql/matviews.sql @@ -3,6 +3,6 @@ -- CREATE MATERIALIZED VIEW pg_class_mv AS - SELECT * FROM pg_class LIMIT 1 WITH NO DATA; + SELECT * FROM datatype_table LIMIT 1 WITH NO DATA; REFRESH MATERIALIZED VIEW pg_class_mv; -- 2.40.0