From a06bf794e590f8876314d6b84ec38c81428e5225 Mon Sep 17 00:00:00 2001
From: Jim Jagielski
From 2.4.13, expression syntax can be + used inside the directive to produce dynamic strings and URLs.
+URLs can begin with a slash (/) for local web-paths (relative
to the
Additionally, the special value default
can be used
diff --git a/include/ap_mmn.h b/include/ap_mmn.h
index ca433d6d4b..a992d3cd31 100644
--- a/include/ap_mmn.h
+++ b/include/ap_mmn.h
@@ -437,6 +437,7 @@
* 20120211.39 (2.4.11-dev) Add ap_proxy_connect_uds().
* 20120211.40 (2.4.11-dev) Add ap_log_data(), ap_log_rdata(), etc.
* 20120211.41 (2.4.11-dev) Add ap_proxy_de_socketfy to mod_proxy.h
+ * 20120211.42 (2.4.13-dev) Add response_code_exprs to http_core.h
*/
#define MODULE_MAGIC_COOKIE 0x41503234UL /* "AP24" */
@@ -444,7 +445,7 @@
#ifndef MODULE_MAGIC_NUMBER_MAJOR
#define MODULE_MAGIC_NUMBER_MAJOR 20120211
#endif
-#define MODULE_MAGIC_NUMBER_MINOR 41 /* 0...n */
+#define MODULE_MAGIC_NUMBER_MINOR 42 /* 0...n */
/**
* Determine if the server's current MODULE_MAGIC_NUMBER is at least a
diff --git a/include/http_core.h b/include/http_core.h
index 5cef6224fc..23db3cfce0 100644
--- a/include/http_core.h
+++ b/include/http_core.h
@@ -497,12 +497,7 @@ typedef struct {
overrides_t override;
allow_options_t override_opts;
- /* Custom response config. These can contain text or a URL to redirect to.
- * if response_code_strings is NULL then there are none in the config,
- * if it's not null then it's allocated to sizeof(char*)*RESPONSE_CODES.
- * This lets us do quick merges in merge_core_dir_configs().
- */
-
+ /* Used to be the custom response config. No longer used. */
char **response_code_strings; /* from ErrorDocument, not from
* ap_custom_response() */
@@ -617,10 +612,15 @@ typedef struct {
/** Max number of Range reversals (eg: 200-300, 100-125) allowed **/
int max_reversals;
-
/** Named back references */
apr_array_header_t *refs;
+ /** Custom response config with expression support. The hash table
+ * contains compiled expressions keyed against the custom response
+ * code.
+ */
+ apr_hash_t *response_code_exprs;
+
} core_dir_config;
/* macro to implement off by default behaviour */
diff --git a/server/core.c b/server/core.c
index e307e92bb2..749cf5c166 100644
--- a/server/core.c
+++ b/server/core.c
@@ -252,23 +252,14 @@ static void *merge_core_dir_configs(apr_pool_t *a, void *basev, void *newv)
conf->override_list = new->override_list;
}
- if (conf->response_code_strings == NULL) {
- conf->response_code_strings = new->response_code_strings;
+ if (conf->response_code_exprs == NULL) {
+ conf->response_code_exprs = new->response_code_exprs;
}
- else if (new->response_code_strings != NULL) {
- /* If we merge, the merge-result must have its own array
- */
- conf->response_code_strings = apr_pmemdup(a,
- base->response_code_strings,
- sizeof(*conf->response_code_strings) * RESPONSE_CODES);
-
- for (i = 0; i < RESPONSE_CODES; ++i) {
- if (new->response_code_strings[i] != NULL) {
- conf->response_code_strings[i] = new->response_code_strings[i];
- }
- }
+ else if (new->response_code_exprs != NULL) {
+ conf->response_code_exprs = apr_hash_overlay(a,
+ new->response_code_exprs, conf->response_code_exprs);
}
- /* Otherwise we simply use the base->response_code_strings array
+ /* Otherwise we simply use the base->response_code_exprs array
*/
if (new->hostname_lookups != HOSTNAME_LOOKUP_UNSET) {
@@ -796,25 +787,46 @@ char *ap_response_code_string(request_rec *r, int error_index)
{
core_dir_config *dirconf;
core_request_config *reqconf = ap_get_core_module_config(r->request_config);
+ const char *err;
+ const char *response;
+ void *val;
+ ap_expr_info_t *expr;
/* check for string registered via ap_custom_response() first */
- if (reqconf->response_code_strings != NULL &&
- reqconf->response_code_strings[error_index] != NULL) {
+ if (reqconf->response_code_strings != NULL
+ && reqconf->response_code_strings[error_index] != NULL) {
return reqconf->response_code_strings[error_index];
}
/* check for string specified via ErrorDocument */
dirconf = ap_get_core_module_config(r->per_dir_config);
- if (dirconf->response_code_strings == NULL) {
+ if (!dirconf->response_code_exprs) {
+ return NULL;
+ }
+
+ expr = apr_hash_get(dirconf->response_code_exprs, &error_index,
+ sizeof(error_index));
+ if (!expr) {
return NULL;
}
- if (dirconf->response_code_strings[error_index] == &errordocument_default) {
+ /* special token to indicate revert back to default */
+ if ((char *) expr == &errordocument_default) {
return NULL;
}
- return dirconf->response_code_strings[error_index];
+ err = NULL;
+ response = ap_expr_str_exec(r, expr, &err);
+ if (err) {
+ ap_log_rerror(
+ APLOG_MARK, APLOG_ERR, 0, r, APLOGNO(02830) "core: ErrorDocument: can't "
+ "evaluate require expression: %s", err);
+ return NULL;
+ }
+
+ /* alas, duplication required as we return not-const */
+ return apr_pstrdup(r->pool, response);
}
@@ -1499,27 +1511,43 @@ static const char *set_error_document(cmd_parms *cmd, void *conf_,
"directive --- ignoring!", cmd->directive->filename, cmd->directive->line_num);
}
else { /* Store it... */
- if (conf->response_code_strings == NULL) {
- conf->response_code_strings =
- apr_pcalloc(cmd->pool,
- sizeof(*conf->response_code_strings) *
- RESPONSE_CODES);
+ if (conf->response_code_exprs == NULL) {
+ conf->response_code_exprs = apr_hash_make(cmd->pool);
}
if (strcasecmp(msg, "default") == 0) {
/* special case: ErrorDocument 404 default restores the
* canned server error response
*/
- conf->response_code_strings[index_number] = &errordocument_default;
+ apr_hash_set(conf->response_code_exprs,
+ apr_pmemdup(cmd->pool, &index_number, sizeof(index_number)),
+ sizeof(index_number), &errordocument_default);
}
else {
+ ap_expr_info_t *expr;
+ const char *expr_err = NULL;
+
/* hack. Prefix a " if it is a msg; as that is what
* http_protocol.c relies on to distinguish between
* a msg and a (local) path.
*/
- conf->response_code_strings[index_number] = (what == MSG) ?
- apr_pstrcat(cmd->pool, "\"", msg, NULL) :
- apr_pstrdup(cmd->pool, msg);
+ const char *response =
+ (what == MSG) ? apr_pstrcat(cmd->pool, "\"", msg, NULL) :
+ apr_pstrdup(cmd->pool, msg);
+
+ expr = ap_expr_parse_cmd(cmd, response, AP_EXPR_FLAG_STRING_RESULT,
+ &expr_err, NULL);
+
+ if (expr_err) {
+ return apr_pstrcat(cmd->temp_pool,
+ "Cannot parse expression in ErrorDocument: ",
+ expr_err, NULL);
+ }
+
+ apr_hash_set(conf->response_code_exprs,
+ apr_pmemdup(cmd->pool, &index_number, sizeof(index_number)),
+ sizeof(index_number), expr);
+
}
}
--
2.50.1