From 9f0a93bdefecc5f98957187373e601a83ac6c86f Mon Sep 17 00:00:00 2001 From: Tom Stellard Date: Wed, 18 May 2016 20:32:40 +0000 Subject: [PATCH] Merging r257915: ------------------------------------------------------------------------ r257915 | rafael.espindola | 2016-01-15 10:23:46 -0800 (Fri, 15 Jan 2016) | 9 lines Don't try to check all uses if lazy loading. This means that LTO_SYMBOL_SCOPE_DEFAULT_CAN_BE_HIDDEN will not be set in a few cases. This should have no impact in ld64 since it doesn't use lazy loading when merging modules and that is when it checks LTO_SYMBOL_SCOPE_DEFAULT_CAN_BE_HIDDEN. ------------------------------------------------------------------------ git-svn-id: https://llvm.org/svn/llvm-project/llvm/branches/release_38@269978 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/CodeGen/Analysis.cpp | 5 +++++ test/LTO/X86/pr25919.ll | 11 +++++++++++ 2 files changed, 16 insertions(+) create mode 100644 test/LTO/X86/pr25919.ll diff --git a/lib/CodeGen/Analysis.cpp b/lib/CodeGen/Analysis.cpp index 75579a2b455..97b692fbe56 100644 --- a/lib/CodeGen/Analysis.cpp +++ b/lib/CodeGen/Analysis.cpp @@ -639,6 +639,11 @@ bool llvm::canBeOmittedFromSymbolTable(const GlobalValue *GV) { if (isa(GV)) return false; + // If we don't see every use, we have to be conservative and assume the value + // address is significant. + if (GV->getParent()->getMaterializer()) + return false; + GlobalStatus GS; if (GlobalStatus::analyzeGlobal(GV, GS)) return false; diff --git a/test/LTO/X86/pr25919.ll b/test/LTO/X86/pr25919.ll new file mode 100644 index 00000000000..b7fe0c636a1 --- /dev/null +++ b/test/LTO/X86/pr25919.ll @@ -0,0 +1,11 @@ +; RUN: llvm-as < %s >%t1 +; RUN: llvm-lto -list-symbols-only %t1 | FileCheck %s + +; This tests that we don't crash trying to find all uses in a lazily loaded +; module. +; CHECK: foo + +target triple = "x86_64-unknown-linux-gnu" +define linkonce_odr void @foo() { + ret void +} -- 2.40.0