From 9ed8bad9d68701fa2acc043b2f063a726528daf9 Mon Sep 17 00:00:00 2001 From: Reid Kleckner Date: Wed, 19 Jul 2017 23:22:06 +0000 Subject: [PATCH] Fix fuzzer-flags.test on Windows The optional external function callbacks have to be exported in order for them to be called. The test was failing because libFuzzer wasn't calling LLVMFuzzerInitialize. We can reconsider if this is the best way to mark these optional callbacks exported later. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@308548 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/Fuzzer/test/CMakeLists.txt | 1 + lib/Fuzzer/test/fuzzer-flags.test | 3 --- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/lib/Fuzzer/test/CMakeLists.txt b/lib/Fuzzer/test/CMakeLists.txt index 43aea2b7a18..28de8dc725d 100644 --- a/lib/Fuzzer/test/CMakeLists.txt +++ b/lib/Fuzzer/test/CMakeLists.txt @@ -158,6 +158,7 @@ function(test_export_symbol target symbol) endif() endfunction() +test_export_symbol(FlagsTest "LLVMFuzzerInitialize") test_export_symbol(InitializeTest "LLVMFuzzerInitialize") test_export_symbol(BogusInitializeTest "LLVMFuzzerInitialize") test_export_symbol(CustomCrossOverTest "LLVMFuzzerCustomCrossOver") diff --git a/lib/Fuzzer/test/fuzzer-flags.test b/lib/Fuzzer/test/fuzzer-flags.test index 976da2906d7..61ce07797b4 100644 --- a/lib/Fuzzer/test/fuzzer-flags.test +++ b/lib/Fuzzer/test/fuzzer-flags.test @@ -1,6 +1,3 @@ -# Does not work on windows for unknown reason. -UNSUPPORTED: windows - RUN: LLVMFuzzer-FlagsTest -foo_bar=1 2>&1 | FileCheck %s --check-prefix=FOO_BAR FOO_BAR: WARNING: unrecognized flag '-foo_bar=1'; use -help=1 to list all flags FOO_BAR: BINGO -- 2.40.0