From 9e26326ad6cd11ac32d11e6cbeb613443f361da6 Mon Sep 17 00:00:00 2001 From: Alvaro Herrera Date: Thu, 28 Jun 2012 23:37:27 -0400 Subject: [PATCH] pg_upgrade: fix off-by-one mistake in snprintf snprintf counts trailing NUL towards the char limit. Failing to account for that was causing an invalid value to be passed to pg_resetxlog -l, aborting the upgrade process. --- contrib/pg_upgrade/controldata.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contrib/pg_upgrade/controldata.c b/contrib/pg_upgrade/controldata.c index 5d5ab854ca..7da19c6c28 100644 --- a/contrib/pg_upgrade/controldata.c +++ b/contrib/pg_upgrade/controldata.c @@ -425,7 +425,7 @@ get_control_data(ClusterInfo *cluster, bool live_check) { if (got_log_id && got_log_seg) { - snprintf(cluster->controldata.nextxlogfile, 24, "%08X%08X%08X", + snprintf(cluster->controldata.nextxlogfile, 25, "%08X%08X%08X", tli, logid, segno); got_nextxlogfile = true; } -- 2.40.0