From 9cdc4d3834f203dcde3ff274b8928e4620a914d5 Mon Sep 17 00:00:00 2001 From: Anders Carlsson Date: Fri, 17 Aug 2007 15:44:17 +0000 Subject: [PATCH] Return true in case of error, which is what other functions do. git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@41140 91177308-0d34-0410-b5e6-96231b3b80d8 --- Sema/SemaChecking.cpp | 8 ++++---- Sema/SemaExpr.cpp | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/Sema/SemaChecking.cpp b/Sema/SemaChecking.cpp index ed4c898349..1917d6317d 100644 --- a/Sema/SemaChecking.cpp +++ b/Sema/SemaChecking.cpp @@ -47,7 +47,7 @@ Sema::CheckFunctionCall(Expr *Fn, // Search the KnownFunctionIDs for the identifier. unsigned i = 0, e = id_num_known_functions; for (; i != e; ++i) { if (KnownFunctionIDs[i] == FnInfo) break; } - if (i == e) return true; + if (i == e) return false; // Printf checking. if (i <= id_vprintf) { @@ -74,7 +74,7 @@ Sema::CheckFunctionCall(Expr *Fn, FDecl, format_idx, Args, NumArgsInCall); } - return true; + return false; } /// CheckBuiltinCFStringArgument - Checks that the argument to the builtin @@ -90,7 +90,7 @@ bool Sema::CheckBuiltinCFStringArgument(Expr* Arg) Diag(Arg->getLocStart(), diag::err_cfstring_literal_not_string_constant, Arg->getSourceRange()); - return false; + return true; } const char *Data = Literal->getStrData(); @@ -112,7 +112,7 @@ bool Sema::CheckBuiltinCFStringArgument(Expr* Arg) } } - return true; + return false; } /// CheckPrintfArguments - Check calls to printf (and similar functions) for diff --git a/Sema/SemaExpr.cpp b/Sema/SemaExpr.cpp index 64769c83d4..3ca766b3a0 100644 --- a/Sema/SemaExpr.cpp +++ b/Sema/SemaExpr.cpp @@ -561,7 +561,7 @@ ParseCallExpr(ExprTy *fn, SourceLocation LParenLoc, if (ImplicitCastExpr *IcExpr = dyn_cast(Fn)) if (DeclRefExpr *DRExpr = dyn_cast(IcExpr->getSubExpr())) if (FunctionDecl *FDecl = dyn_cast(DRExpr->getDecl())) - if (!CheckFunctionCall(Fn, LParenLoc, RParenLoc, FDecl, Args, NumArgsInCall)) + if (CheckFunctionCall(Fn, LParenLoc, RParenLoc, FDecl, Args, NumArgsInCall)) return true; return new CallExpr(Fn, Args, NumArgsInCall, resultType, RParenLoc); -- 2.40.0