From 9cd9717f21cd4f77d41f5de701f8f3d5e8175b45 Mon Sep 17 00:00:00 2001 From: Michael Smith Date: Mon, 9 May 2005 08:41:52 +0000 Subject: [PATCH] ::Problem: PAGE UP, PAGE DOWN, and HOME keyboard shortcuts not longer work as expected ::Cause: Shortcuts were replaced with letter-key shortcuts (N, P, H). ::Fix: Restored PAGE UP, PAGE DOWN, and HOME shortcuts by appending those keys to the list of valid shortcuts. Now, both those and the letter-key shortcuts are available. Also, added RIGHT ARROW, LEFT ARROW, and UP ARROW shortcuts. The complete list of shortcuts is now: * forward = n, N, SPACE, ENTER, RETURN, PAGE UP, RIGHT ARROW * backward = p, P, BACKSPACE, PAGE DOWN, LEFT ARROW * up = u, U, UP ARROW * home = h, H, HOME * toc = t, T (Closes bug #1196429; thanks to Roland Huss for reporting the problem) --- slides/browser/slides.js | 24 +++++++++++++----------- 1 file changed, 13 insertions(+), 11 deletions(-) diff --git a/slides/browser/slides.js b/slides/browser/slides.js index 867637853..abc56d903 100644 --- a/slides/browser/slides.js +++ b/slides/browser/slides.js @@ -53,18 +53,20 @@ function navigate (evt) { kc = evt.which; } - // These do look like odd values, what was the story? - //var forward = (kc == 34); /* '"' ? */ - //var backward = (kc == 33); /* '!' */ - //var home = (kc == 36); /* '$' */ - //var toc = (kc == 112) || (kc == 224); - var forward = (kc == 110) || (kc == 78) || (kc == 32) - || (kc == 10) || (kc == 13); /* n, N, SPACE, ENTER, RETURN */ - var backward = (kc == 112) || (kc == 80) || (kc == 8); /* p, P, BACKSPACE */ - var up = (kc == 117) || (kc == 85); /* u, U */ - var home = (kc == 104) || (kc == 72); /* h, H */ - var toc = (kc == 116) || (kc == 84); /* t, T */ + || (kc == 10) || (kc == 13) || (kc == 34) + || (kc == 39); + /* n, N, SPACE, ENTER, RETURN, PAGE UP, RIGHT ARROW */ + var backward = (kc == 112) || (kc == 80) || (kc == 8) + || (kc == 33) || (kc == 37); + /* p, P, BACKSPACE, PAGE DOWN, LEFT ARROW */ + var up = (kc == 117) || (kc == 85) || (kc == 38); + /* u, U, UP ARROW */ + var home = (kc == 104) || (kc == 72) || (kc == 36); + /* h, H, HOME */ + var toc = (kc == 116) || (kc == 84); + /* t, T */ + /* previously included META (kc == 244) */ var links = document.getElementsByTagName("link"); -- 2.40.0