From 9c9b5b39256b54a64412d6f5ff5c780f70feec2e Mon Sep 17 00:00:00 2001 From: Ilia Alshanetsky Date: Thu, 13 Nov 2008 18:21:40 +0000 Subject: [PATCH] Fixed a bug inside dba_replace() that could cause file truncation with invalid keys --- ext/dba/libinifile/inifile.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/ext/dba/libinifile/inifile.c b/ext/dba/libinifile/inifile.c index 237ec57386..e5b2940a48 100644 --- a/ext/dba/libinifile/inifile.c +++ b/ext/dba/libinifile/inifile.c @@ -508,7 +508,9 @@ static int inifile_delete_replace_append(inifile *dba, const key_type *key, cons /* 5 */ if (ret == SUCCESS) { - ret = inifile_truncate(dba, append ? pos_grp_next : pos_grp_start TSRMLS_CC); /* writes error on fail */ + if (!value || (key->name && strlen(key->name))) { + ret = inifile_truncate(dba, append ? pos_grp_next : pos_grp_start TSRMLS_CC); /* writes error on fail */ + } } if (ret == SUCCESS) { -- 2.50.1