From 9c963f9ed1cc48fffbe22d029f6b99c0cbfead96 Mon Sep 17 00:00:00 2001 From: Stefan Fritsch Date: Wed, 5 Dec 2012 22:11:25 +0000 Subject: [PATCH] vote, comment git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x@1417670 13f79535-47bb-0310-9956-ffa450edef68 --- STATUS | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/STATUS b/STATUS index 3318ddae22..8a4885edf0 100644 --- a/STATUS +++ b/STATUS @@ -198,15 +198,21 @@ PATCHES PROPOSED TO BACKPORT FROM TRUNK: trunk patch: http://svn.apache.org/viewvc?rev=1404625&view=rev 2.4.x patch: trunk patch works: +1: jim, druggeri + sf notes: The if (!epsv_addr) check is wrong: the return value of + apr_sockaddr_info_get() should be checked instead, or + epsv_addr needs to be initialized to NULL. + The if (!data_sock) case can never be hit because + apr_socket_create() never returns a NULL socket when it also + returns APR_SUCCESS. And if data_sock were NULL, the + apr_socket_opt_set() call would segfault before the check is + hit. + -1: sf (until at least the epsv_addr check is fixed) * mod_proxy: Allow for setting of sticky session split char... PR 53893. trunk patch: http://svn.apache.org/viewvc?rev=1404653&view=rev 2.4.x patch: http://people.apache.org/~jim/patches/sticky-sep-2.4.patch - +1: jim, covener - sf: doesn't the new element in proxy_balancer_shared need to be at the - end of the struct? (druggeri agrees) - jim: Fixed in 2.4 specific patch (*sob*... bitfields no longer at end) + +1: jim, covener, sf * mod_proxy_balancer: Bring XML output up to date. http://svn.apache.org/viewvc?view=revision&revision=1392345 -- 2.40.0