From 9c38a33be893d7ba28c0fda67ef6c07e83cc9a94 Mon Sep 17 00:00:00 2001 From: Ehsan Akhgari Date: Fri, 12 Sep 2014 21:44:24 +0000 Subject: [PATCH] clang-cl: Warn when a /TC or /TP argument is unused Test Plan: The patch includes a test case. Reviewers: hansw Subscribers: cfe-commits Differential Revision: http://reviews.llvm.org/D5338 git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@217710 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/Driver/Driver.cpp | 4 ++-- test/Driver/cl-inputs.c | 6 ++++-- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/lib/Driver/Driver.cpp b/lib/Driver/Driver.cpp index e448eb153a..c4d983fa2d 100644 --- a/lib/Driver/Driver.cpp +++ b/lib/Driver/Driver.cpp @@ -987,8 +987,8 @@ void Driver::BuildInputs(const ToolChain &TC, DerivedArgList &Args, Arg *InputTypeArg = nullptr; // The last /TC or /TP option sets the input type to C or C++ globally. - if (Arg *TCTP = Args.getLastArg(options::OPT__SLASH_TC, - options::OPT__SLASH_TP)) { + if (Arg *TCTP = Args.getLastArgNoClaim(options::OPT__SLASH_TC, + options::OPT__SLASH_TP)) { InputTypeArg = TCTP; InputType = TCTP->getOption().matches(options::OPT__SLASH_TC) ? types::TY_C : types::TY_CXX; diff --git a/test/Driver/cl-inputs.c b/test/Driver/cl-inputs.c index c0d4778d76..b0265df52f 100644 --- a/test/Driver/cl-inputs.c +++ b/test/Driver/cl-inputs.c @@ -34,12 +34,14 @@ // WARN: note: The last /TC or /TP option takes precedence over earlier instances // WARN-NOT: note -// RUN: env LIB=%S/Inputs/cl-libs %clang_cl /c /TP cl-test.lib %s -### 2>&1 | FileCheck -check-prefix=TPlib %s +// RUN: env LIB=%S/Inputs/cl-libs %clang_cl /c /TP cl-test.lib -### 2>&1 | FileCheck -check-prefix=TPlib %s // TPlib: warning: cl-test.lib: 'linker' input unused +// TPlib: warning: argument unused during compilation: '/TP' // TPlib-NOT: cl-test.lib -// RUN: env LIB=%S/Inputs/cl-libs %clang_cl /c /TC cl-test.lib %s -### 2>&1 | FileCheck -check-prefix=TClib %s +// RUN: env LIB=%S/Inputs/cl-libs %clang_cl /c /TC cl-test.lib -### 2>&1 | FileCheck -check-prefix=TClib %s // TClib: warning: cl-test.lib: 'linker' input unused +// TClib: warning: argument unused during compilation: '/TC' // TClib-NOT: cl-test.lib // RUN: not %clang_cl - 2>&1 | FileCheck -check-prefix=STDIN %s -- 2.40.0