From 9bcd4d4a4b9281ba3526b0e86e6d422db93a9074 Mon Sep 17 00:00:00 2001
From: Douglas Gregor <dgregor@apple.com>
Date: Tue, 10 Aug 2010 14:27:00 +0000
Subject: [PATCH] Eliminate unnecessary uses of TemporaryBase in TreeTransform;
 transforming TypeSourceInfos already gives us proper (and better)
 source-location information.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@110678 91177308-0d34-0410-b5e6-96231b3b80d8
---
 lib/Sema/TreeTransform.h | 29 ++++++++++-------------------
 1 file changed, 10 insertions(+), 19 deletions(-)

diff --git a/lib/Sema/TreeTransform.h b/lib/Sema/TreeTransform.h
index 1ff6d5335d..eaf47a673b 100644
--- a/lib/Sema/TreeTransform.h
+++ b/lib/Sema/TreeTransform.h
@@ -4783,14 +4783,9 @@ TreeTransform<Derived>::TransformImplicitValueInitExpr(
 template<typename Derived>
 Sema::OwningExprResult
 TreeTransform<Derived>::TransformVAArgExpr(VAArgExpr *E) {
-  TypeSourceInfo *TInfo;
-  {
-    // FIXME: Source location isn't quite accurate.
-    TemporaryBase Rebase(*this, E->getBuiltinLoc(), DeclarationName());
-    TInfo = getDerived().TransformType(E->getWrittenTypeInfo());
-    if (!TInfo)
-      return SemaRef.ExprError();
-  }
+  TypeSourceInfo *TInfo = getDerived().TransformType(E->getWrittenTypeInfo());
+  if (!TInfo)
+    return SemaRef.ExprError();
 
   OwningExprResult SubExpr = getDerived().TransformExpr(E->getSubExpr());
   if (SubExpr.isInvalid())
@@ -4858,18 +4853,14 @@ Sema::OwningExprResult
 TreeTransform<Derived>::TransformTypesCompatibleExpr(TypesCompatibleExpr *E) {
   TypeSourceInfo *TInfo1;
   TypeSourceInfo *TInfo2;
-  {
-    // FIXME: Source location isn't quite accurate.
-    TemporaryBase Rebase(*this, E->getBuiltinLoc(), DeclarationName());
-
-    TInfo1 = getDerived().TransformType(E->getArgTInfo1());
-    if (!TInfo1)
-      return SemaRef.ExprError();
+  
+  TInfo1 = getDerived().TransformType(E->getArgTInfo1());
+  if (!TInfo1)
+    return SemaRef.ExprError();
 
-    TInfo2 = getDerived().TransformType(E->getArgTInfo2());
-    if (!TInfo2)
-      return SemaRef.ExprError();
-  }
+  TInfo2 = getDerived().TransformType(E->getArgTInfo2());
+  if (!TInfo2)
+    return SemaRef.ExprError();
 
   if (!getDerived().AlwaysRebuild() &&
       TInfo1 == E->getArgTInfo1() &&
-- 
2.40.0