From 9b44eaf402c991d20306e6224a6ce6e4ea02ce48 Mon Sep 17 00:00:00 2001 From: Ted Kremenek Date: Thu, 5 Aug 2010 15:03:30 +0000 Subject: [PATCH] Revert r110317, and add a comment why the assertion is not an invariant. git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@110330 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/Checker/GRExprEngine.cpp | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/Checker/GRExprEngine.cpp b/lib/Checker/GRExprEngine.cpp index d4ee0efb54..4ecc75f105 100644 --- a/lib/Checker/GRExprEngine.cpp +++ b/lib/Checker/GRExprEngine.cpp @@ -236,11 +236,11 @@ void GRExprEngine::CheckerVisit(const Stmt *S, ExplodedNodeSet &Dst, // If we built NewCO, check if we called all the checkers. This is important // so that we know that we accurately determined the entire set of checkers - // that responds to this callback. - if (NewCO.get()) { - assert(checkersEvaluated == Checkers.size()); + // that responds to this callback. Note that 'checkersEvaluated' might + // not be the same as Checkers.size() if one of the Checkers generates + // a sink node. + if (NewCO.get() && checkersEvaluated == Checkers.size()) CO_Ref = NewCO.take(); - } // Don't autotransition. The CheckerContext objects should do this // automatically. -- 2.40.0