From 9adba39460dfa5282b75dbd27db44ccfb4d1f511 Mon Sep 17 00:00:00 2001 From: Rafael Espindola Date: Wed, 5 Jun 2013 04:28:55 +0000 Subject: [PATCH] Default to PIE and using stack protection on OpenBSD. Patch by Matthew Dempsky. git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@183295 91177308-0d34-0410-b5e6-96231b3b80d8 --- include/clang/Driver/Options.td | 1 + lib/Driver/ToolChains.h | 5 +++++ lib/Driver/Tools.cpp | 3 +++ test/Driver/pic.c | 12 ++++++++++++ test/Driver/stack-protector.c | 6 ++++++ 5 files changed, 27 insertions(+) diff --git a/include/clang/Driver/Options.td b/include/clang/Driver/Options.td index a2d7688cf3..4073d857a4 100644 --- a/include/clang/Driver/Options.td +++ b/include/clang/Driver/Options.td @@ -1007,6 +1007,7 @@ def nodefaultlibs : Flag<["-"], "nodefaultlibs">; def nofixprebinding : Flag<["-"], "nofixprebinding">; def nolibc : Flag<["-"], "nolibc">; def nomultidefs : Flag<["-"], "nomultidefs">; +def nopie : Flag<["-"], "nopie">; def noprebind : Flag<["-"], "noprebind">; def noseglinkedit : Flag<["-"], "noseglinkedit">; def nostartfiles : Flag<["-"], "nostartfiles">; diff --git a/lib/Driver/ToolChains.h b/lib/Driver/ToolChains.h index 3afd8dd228..0827dba26b 100644 --- a/lib/Driver/ToolChains.h +++ b/lib/Driver/ToolChains.h @@ -427,6 +427,11 @@ public: virtual bool IsMathErrnoDefault() const { return false; } virtual bool IsObjCNonFragileABIDefault() const { return true; } + virtual bool isPIEDefault() const { return true; } + + virtual unsigned GetDefaultStackProtectorLevel(bool KernelOrKext) const { + return 1; + } protected: virtual Tool *buildAssembler() const; diff --git a/lib/Driver/Tools.cpp b/lib/Driver/Tools.cpp index 106c642b44..e95d49dd49 100644 --- a/lib/Driver/Tools.cpp +++ b/lib/Driver/Tools.cpp @@ -5165,6 +5165,9 @@ void openbsd::Link::ConstructJob(Compilation &C, const JobAction &JA, } } + if (Args.hasArg(options::OPT_nopie)) + CmdArgs.push_back("-nopie"); + if (Output.isFilename()) { CmdArgs.push_back("-o"); CmdArgs.push_back(Output.getFilename()); diff --git a/test/Driver/pic.c b/test/Driver/pic.c index 3faed2d18f..30e1005c97 100644 --- a/test/Driver/pic.c +++ b/test/Driver/pic.c @@ -24,6 +24,8 @@ // CHECK-PIE-LD: "Scrt1.o" "crti.o" "crtbeginS.o" // CHECK-PIE-LD: "crtendS.o" "crtn.o" // +// CHECK-NOPIE-LD: "-nopie" +// // CHECK-DYNAMIC-NO-PIC-32: "-mrelocation-model" "dynamic-no-pic" // CHECK-DYNAMIC-NO-PIC-32-NOT: "-pic-level" // CHECK-DYNAMIC-NO-PIC-32-NOT: "-pie-level" @@ -197,3 +199,13 @@ // RUN: | FileCheck %s --check-prefix=CHECK-NO-PIC // RUN: %clang -c %s -target armv7-apple-ios -fapple-kext -miphoneos-version-min=6.0.0 -static -### 2>&1 \ // RUN: | FileCheck %s --check-prefix=CHECK-NO-PIC +// +// On OpenBSD, PIE is enabled by default, but can be disabled. +// RUN: %clang -c %s -target i386-pc-openbsd -### 2>&1 \ +// RUN: | FileCheck %s --check-prefix=CHECK-PIE2 +// RUN: %clang -c %s -target i386-pc-openbsd -fno-pie -### 2>&1 \ +// RUN: | FileCheck %s --check-prefix=CHECK-NO-PIC +// +// On OpenBSD, -nopie needs to be passed through to the linker. +// RUN: %clang %s -target i386-pc-openbsd -nopie -### 2>&1 \ +// RUN: | FileCheck %s --check-prefix=CHECK-NOPIE-LD diff --git a/test/Driver/stack-protector.c b/test/Driver/stack-protector.c index 5f3d679c1a..2eb0f53530 100644 --- a/test/Driver/stack-protector.c +++ b/test/Driver/stack-protector.c @@ -9,3 +9,9 @@ // RUN: %clang -fstack-protector --param ssp-buffer-size=16 -### %s 2>&1 | FileCheck %s -check-prefix=SSP-BUF // SSP-BUF: "-stack-protector" "1" // SSP-BUF: "-stack-protector-buffer-size" "16" + +// RUN: %clang -target i386-pc-openbsd -### %s 2>&1 | FileCheck %s -check-prefix=OPENBSD +// OPENBSD: "-stack-protector" "1" + +// RUN: %clang -target i386-pc-openbsd -fno-stack-protector -### %s 2>&1 | FileCheck %s -check-prefix=OPENBSD_OFF +// OPENBSD_OFF-NOT: "-stack-protector" -- 2.40.0