From 9a50a93c7b1427f6182ed1f21ed76da5b1d6a57c Mon Sep 17 00:00:00 2001 From: Tom Lane Date: Tue, 26 Sep 2017 15:25:56 -0400 Subject: [PATCH] Improve wording of error message added in commit 714805010. Per suggestions from Peter Eisentraut and David Johnston. Back-patch, like the previous commit. Discussion: https://postgr.es/m/E1dv9jI-0006oT-Fn@gemulon.postgresql.org --- src/backend/commands/analyze.c | 2 +- src/test/regress/expected/vacuum.out | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/backend/commands/analyze.c b/src/backend/commands/analyze.c index 1248b2ee5c..283845cf2a 100644 --- a/src/backend/commands/analyze.c +++ b/src/backend/commands/analyze.c @@ -396,7 +396,7 @@ do_analyze_rel(Relation onerel, int options, VacuumParams *params, if (bms_is_member(i, unique_cols)) ereport(ERROR, (errcode(ERRCODE_DUPLICATE_COLUMN), - errmsg("column \"%s\" of relation \"%s\" is specified twice", + errmsg("column \"%s\" of relation \"%s\" appears more than once", col, RelationGetRelationName(onerel)))); unique_cols = bms_add_member(unique_cols, i); diff --git a/src/test/regress/expected/vacuum.out b/src/test/regress/expected/vacuum.out index a16f26da7e..ced53ca9aa 100644 --- a/src/test/regress/expected/vacuum.out +++ b/src/test/regress/expected/vacuum.out @@ -92,7 +92,7 @@ VACUUM (FULL) vacparted; VACUUM (FREEZE) vacparted; -- check behavior with duplicate column mentions VACUUM ANALYZE vacparted(a,b,a); -ERROR: column "a" of relation "vacparted" is specified twice +ERROR: column "a" of relation "vacparted" appears more than once ANALYZE vacparted(a,b,b); -ERROR: column "b" of relation "vacparted" is specified twice +ERROR: column "b" of relation "vacparted" appears more than once DROP TABLE vacparted; -- 2.40.0